Paths

Table of Contentst

Differential D37721

Bug 1565214 - Set the property restrictions flags from the centralized list. r=boris,#style
ClosedPublic
Actions

Authored by emilio on Jul 11 2019, 1:26 PM.

Tags

None

Subscribers

None

Details

Reviewers

Commits

rMOZILLACENTRAL29438d93b50a: Bug 1565214 - Set the property restrictions flags from the centralized list.

Bugzilla Bug ID

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

emilio created this revision.Jul 11 2019, 1:26 PM

Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2019, 1:26 PM

Harbormaster completed remote builds in B91549: Diff 130669.Jul 11 2019, 1:26 PM

phab-bot requested review of this revision.Jul 11 2019, 1:26 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: Restricted Project.

r=me with the question addressed. Overall looks good to me.

servo/components/style/properties/longhands/effects.mako.rs
15	Do we intentionally remove `CREATES_STACKING_CONTEXT` from opacity? It seems `opacity` needs to create stacking context if its value is less than 1.

This revision is now accepted and ready to land.Jul 11 2019, 9:35 PM

boris removed a reviewer: Restricted Project.Jul 11 2019, 9:35 PM

emilio marked an inline comment as done.Jul 11 2019, 10:54 PM

emilio added inline comments.

servo/components/style/properties/longhands/effects.mako.rs
15	No, this is an oversight, awesome catch. It seems we don't have any test to check whether `will-change: opacity` creates a stacking context (which is what this flag affects).

fixes + rebase

emilio edited the summary of this revision. (Show Details)Jul 11 2019, 11:07 PM

Harbormaster completed remote builds in B91784: Diff 131010.Jul 11 2019, 11:07 PM

Closed by commit rMOZILLACENTRAL29438d93b50a: Bug 1565214 - Set the property restrictions flags from the centralized list. (authored by emilio). · Explain WhyJul 11 2019, 11:18 PM

This revision was automatically updated to reflect the committed changes.

emilio added a commit: rMOZILLACENTRAL29438d93b50a: Bug 1565214 - Set the property restrictions flags from the centralized list..

Revision Contents
Changeset List

Path

Size

servo/

components/

style/

properties/

longhands/

background.mako.rs

11 lines

10 lines

5 lines

counters.mako.rs

1 line

effects.mako.rs

4 lines

19 lines

inherited_box.mako.rs

2 lines

inherited_text.mako.rs

16 lines

2 lines

outline.mako.rs

3 lines

padding.mako.rs

2 lines

6 lines

properties.mako.rs

38 lines

Diff 131015

servo/components/style/properties/longhands/background.mako.rs

Loading...

servo/components/style/properties/longhands/border.mako.rs

Loading...

servo/components/style/properties/longhands/box.mako.rs

Loading...

servo/components/style/properties/longhands/counters.mako.rs

Loading...

servo/components/style/properties/longhands/effects.mako.rs

Loading...

servo/components/style/properties/longhands/font.mako.rs

Loading...

servo/components/style/properties/longhands/inherited_box.mako.rs

Loading...

servo/components/style/properties/longhands/inherited_text.mako.rs

Loading...

servo/components/style/properties/longhands/margin.mako.rs

Loading...

servo/components/style/properties/longhands/outline.mako.rs

Loading...

servo/components/style/properties/longhands/padding.mako.rs

Loading...

servo/components/style/properties/longhands/text.mako.rs

Loading...

servo/components/style/properties/properties.mako.rs

Loading...