Paths

Table of Contentst

Differential D37720

Bug 1565214 - Centralize property restrictions. r=boris,#style
ClosedPublic
Actions

Authored by emilio on Jul 11 2019, 1:26 PM.

Tags

None

Subscribers

None

Details

Reviewers

Commits

rMOZILLACENTRAL9893d5f0a7ba: Bug 1565214 - Centralize property restrictions. r=boris

Bugzilla Bug ID

Summary

The assertion in properties.mako.rs ensures I got this right.

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

emilio created this revision.Jul 11 2019, 1:26 PM

Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2019, 1:26 PM

Harbormaster completed remote builds in B91548: Diff 130668.Jul 11 2019, 1:26 PM

phab-bot requested review of this revision.Jul 11 2019, 1:26 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: Restricted Project.

emilio added a child revision: D37721: Bug 1565214 - Set the property restrictions flags from the centralized list. r=boris,#style.Jul 11 2019, 1:26 PM

code-wise looks good.

servo/components/style/properties/data.py
652	The spec of `:first-letter` and `:first-line` mentions `opacity`, but it's not in the list. Is it a Gecko bug or spec issue?
663	nit: `initial-letter` and `vertical-align` might be group as "any inline layout properties that apply to inline elements"? Hmm. Anyway, this classification is ok for me.
747–762	nit: Should we include `line-height` (per spec)?

This revision is now accepted and ready to land.Jul 11 2019, 9:02 PM

boris removed a reviewer: Restricted Project.Jul 11 2019, 9:03 PM

emilio marked 2 inline comments as done.Jul 11 2019, 10:52 PM

emilio added inline comments.

servo/components/style/properties/data.py
652	Gecko bug, afaict.
663	Yeah, that's fair. That was a very ambiguous classification.
747–762	It's already included since it's a part of the font shorthand.

fixes + rebase

Harbormaster completed remote builds in B91782: Diff 131008.Jul 11 2019, 11:06 PM

emilio edited the summary of this revision. (Show Details)Jul 11 2019, 11:06 PM

Closed by commit rMOZILLACENTRAL9893d5f0a7ba: Bug 1565214 - Centralize property restrictions. r=boris (authored by emilio). · Explain WhyJul 11 2019, 11:18 PM

This revision was automatically updated to reflect the committed changes.

emilio added a commit: rMOZILLACENTRAL9893d5f0a7ba: Bug 1565214 - Centralize property restrictions. r=boris.

Revision Contents
Changeset List

Path

Size

servo/

components/

style/

properties/

171 lines

properties.mako.rs

16 lines

Diff 131014

servo/components/style/properties/data.py

Loading...

servo/components/style/properties/properties.mako.rs

Loading...