Differential D37719

Bug 1565214 - scroll-margin properties shouldn't apply to first-line / first-letter. r=boris,#style
ClosedPublic
Actions

Authored by emilio on Jul 11 2019, 1:25 PM.

Details

Reviewers

boris

Commits

rMOZILLACENTRALa72cf3fdb84b: Bug 1565214 - scroll-margin properties shouldn't apply to first-line / first…

Bugzilla Bug ID

1565214

Summary

From https://drafts.csswg.org/css-scroll-snap-1/#placement:

None of the properties in this module apply to the ::first-line and
::first-letter pseudo-elements.

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

emilio created this revision.Jul 11 2019, 1:25 PM

Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2019, 1:25 PM

Harbormaster completed remote builds in B91547: Diff 130667.Jul 11 2019, 1:25 PM

phab-bot requested review of this revision.Jul 11 2019, 1:25 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: Restricted Project.

emilio added a child revision: D37720: Bug 1565214 - Centralize property restrictions. r=boris,#style.Jul 11 2019, 1:26 PM

Make sense.

This revision is now accepted and ready to land.Jul 11 2019, 7:44 PM

boris removed a reviewer: Restricted Project.Jul 11 2019, 7:44 PM

fixes + rebase

Harbormaster completed remote builds in B91781: Diff 131007.Jul 11 2019, 11:06 PM

emilio edited the summary of this revision. (Show Details)Jul 11 2019, 11:06 PM

Closed by commit rMOZILLACENTRALa72cf3fdb84b: Bug 1565214 - scroll-margin properties shouldn't apply to first-line / first… (authored by emilio). · Explain WhyJul 11 2019, 11:18 PM

This revision was automatically updated to reflect the committed changes.

emilio added a commit: rMOZILLACENTRALa72cf3fdb84b: Bug 1565214 - scroll-margin properties shouldn't apply to first-line / first….

Revision Contents
Changeset List

Path

Size

layout/

style/

test/

property_database.js

16 lines

servo/

components/

style/

properties/

longhands/

margin.mako.rs

1 line

Diff 131013

View Options

layout/style/test/property_database.js