Page MenuHomePhabricator
Differential D36504

Bug 1562680. Implement the new syntax for Web IDL dictionary defaulting. r=peterv
ClosedPublic
Actions

Authored by bzbarsky on Jul 1 2019, 4:51 PM.

Details

Reviewers
peterv
Commits
rMOZILLACENTRAL59c08b215af5: Bug 1562680. Implement the new syntax for Web IDL dictionary defaulting.
rMOZILLACENTRAL8e16f13a88c8: Bug 1562680. Implement the new syntax for Web IDL dictionary defaulting.
rMOZILLACENTRAL12653dd76667: Bug 1562680. Implement the new syntax for Web IDL dictionary defaulting.
Bugzilla Bug ID
1562680
Summary

= {} can now be used to indicate that an optional dictionary should have the
default value of 'default-initialized dictionary'

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bzbarsky created this revision.Jul 1 2019, 4:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 1 2019, 4:51 PM
Harbormaster completed remote builds in B87886: Diff 125539.Jul 1 2019, 4:51 PM
phab-bot requested review of this revision.Jul 1 2019, 4:51 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.
peterv accepted this revision.Jul 2 2019, 9:26 AM
peterv added inline comments.
dom/bindings/Codegen.py
6204–6206

I'm not sure if this comment needs updating or not, does it refer to the default value or the jsval ("we only handle null anyway")?

6213

does

dom/chrome-webidl/MessageManager.webidl
222

Wouldn't it make sense to make this non-optional?

This revision is now accepted and ready to land.Jul 2 2019, 9:26 AM
bzbarsky updated this revision to Diff 126371.Jul 3 2019, 6:07 AM
bzbarsky marked 3 inline comments as done.

Address review comments

Harbormaster completed remote builds in B88482: Diff 126371.Jul 3 2019, 6:07 AM
bzbarsky added inline comments.Jul 3 2019, 6:07 AM
dom/bindings/Codegen.py
6204–6206

It was referring to the default value. I updated it to be clearer.

6213

Good catch, fixed.

dom/chrome-webidl/MessageManager.webidl
222

Right you are. Done, and the comment removed.

bzbarsky updated this revision to Diff 126372.Jul 3 2019, 6:15 AM

Merge to tip

Harbormaster completed remote builds in B88483: Diff 126372.Jul 3 2019, 6:15 AM
Closed by commit rMOZILLACENTRAL12653dd76667: Bug 1562680. Implement the new syntax for Web IDL dictionary defaulting. (authored by bzbarsky). · Explain WhyJul 3 2019, 6:24 AM
This revision was automatically updated to reflect the committed changes.
bzbarsky added a commit: rMOZILLACENTRAL12653dd76667: Bug 1562680. Implement the new syntax for Web IDL dictionary defaulting..
Mihai Alexandru Michis <malexandru@mozilla.com> reopened this revision.Jul 3 2019, 6:39 AM
This revision is now accepted and ready to land.Jul 3 2019, 6:39 AM
Mihai Alexandru Michis <malexandru@mozilla.com> added a reverting change: rMOZILLACENTRALea1bdf131082: Backed out changeset 12653dd76667 (bug 1562680) for causing bustages in….Jul 3 2019, 6:39 AM
bzbarsky updated this revision to Diff 126380.Jul 3 2019, 6:44 AM

Fix FuzzingFunctions too

Harbormaster completed remote builds in B88488: Diff 126380.Jul 3 2019, 6:44 AM
Closed by commit rMOZILLACENTRAL8e16f13a88c8: Bug 1562680. Implement the new syntax for Web IDL dictionary defaulting. (authored by bzbarsky). · Explain WhyJul 3 2019, 6:49 AM
This revision was automatically updated to reflect the committed changes.
bzbarsky added a commit: rMOZILLACENTRAL8e16f13a88c8: Bug 1562680. Implement the new syntax for Web IDL dictionary defaulting..
Cosmin Sabou <csabou@mozilla.com> reopened this revision.Jul 3 2019, 7:52 AM
This revision is now accepted and ready to land.Jul 3 2019, 7:52 AM
Cosmin Sabou <csabou@mozilla.com> added a reverting change: rMOZILLACENTRAL6430800a95e1: Backed out changeset 8e16f13a88c8 (bug 1562680) for colliding with Bug 1366738….Jul 3 2019, 7:52 AM
Closed by commit rMOZILLACENTRAL59c08b215af5: Bug 1562680. Implement the new syntax for Web IDL dictionary defaulting. (authored by bzbarsky). · Explain WhyJul 3 2019, 4:06 PM
This revision was automatically updated to reflect the committed changes.
bzbarsky added a commit: rMOZILLACENTRAL59c08b215af5: Bug 1562680. Implement the new syntax for Web IDL dictionary defaulting..

Large Diff

This large diff affects 194 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

PathSize
dom/
bindings/
17 lines
parser/
58 lines
tests/
82 lines
27 lines
test/
30 lines
26 lines
26 lines
chrome-webidl/
4 lines
22 lines
2 lines
6 lines
4 lines
4 lines
2 lines
4 lines
4 lines
webidl/
2 lines
2 lines
4 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
8 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
12 lines
2 lines
2 lines
12 lines
4 lines
16 lines
4 lines
2 lines
2 lines
2 lines
20 lines
2 lines
2 lines
8 lines
2 lines
2 lines
2 lines
10 lines
2 lines
2 lines
2 lines
4 lines
2 lines
2 lines
6 lines
4 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
4 lines
8 lines
4 lines
4 lines
2 lines
2 lines
2 lines
8 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
4 lines
2 lines
2 lines
2 lines
4 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
6 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
8 lines
4 lines
2 lines
2 lines
2 lines
16 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
4 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
4 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
6 lines
2 lines
2 lines
8 lines
4 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
16 lines
2 lines
32 lines
6 lines
2 lines
14 lines
2 lines
4 lines
2 lines
4 lines
2 lines

Diff 126651

View Options

dom/bindings/Codegen.py

Loading...
View Options

dom/bindings/parser/WebIDL.py

View Options

dom/bindings/parser/tests/test_dictionary.py

View Options

dom/bindings/parser/tests/test_distinguishability.py

View Options

dom/bindings/test/TestCodeGen.webidl

View Options

dom/bindings/test/TestExampleGen.webidl

View Options

dom/bindings/test/TestJSImplGen.webidl

View Options

dom/chrome-webidl/ChannelWrapper.webidl

View Options

dom/chrome-webidl/ChromeUtils.webidl

View Options

dom/chrome-webidl/InspectorUtils.webidl

View Options

dom/chrome-webidl/JSWindowActor.webidl

View Options

dom/chrome-webidl/L10nOverlays.webidl

View Options

dom/chrome-webidl/MatchPattern.webidl

View Options

dom/chrome-webidl/MessageManager.webidl

Loading...
View Options

dom/chrome-webidl/SessionStoreUtils.webidl

View Options

dom/chrome-webidl/TelemetryStopwatch.webidl

View Options

dom/webidl/AddonManager.webidl

View Options

dom/webidl/AnalyserNode.webidl

View Options

dom/webidl/Animatable.webidl

View Options

dom/webidl/AnimationEffect.webidl

View Options

dom/webidl/AnimationEvent.webidl

View Options

dom/webidl/AnimationPlaybackEvent.webidl

View Options

dom/webidl/AnonymousContent.webidl

View Options

dom/webidl/AppNotificationServiceOptions.webidl

View Options

dom/webidl/AudioBufferSourceNode.webidl

View Options

dom/webidl/AudioContext.webidl

View Options

dom/webidl/AudioWorkletNode.webidl

View Options

dom/webidl/AudioWorkletProcessor.webidl

View Options

dom/webidl/BaseAudioContext.webidl

View Options

dom/webidl/BiquadFilterNode.webidl

View Options

dom/webidl/Blob.webidl

View Options

dom/webidl/BlobEvent.webidl

View Options

dom/webidl/CSPReport.webidl

View Options

dom/webidl/Cache.webidl

View Options

dom/webidl/CacheStorage.webidl

View Options

dom/webidl/CanvasRenderingContext2D.webidl

View Options

dom/webidl/CaretStateChangedEvent.webidl

View Options

dom/webidl/ChannelMergerNode.webidl

View Options

dom/webidl/ChannelSplitterNode.webidl

View Options

dom/webidl/Client.webidl

View Options

dom/webidl/Clients.webidl

View Options

dom/webidl/ClipboardEvent.webidl

View Options

dom/webidl/CloseEvent.webidl

View Options

dom/webidl/CompositionEvent.webidl

View Options

dom/webidl/Console.webidl

View Options

dom/webidl/ConstantSourceNode.webidl

View Options

dom/webidl/ConvolverNode.webidl

View Options

dom/webidl/CredentialManagement.webidl

View Options

dom/webidl/CustomElementRegistry.webidl

View Options

dom/webidl/CustomEvent.webidl

View Options

dom/webidl/DOMMatrix.webidl

View Options

dom/webidl/DOMPoint.webidl

View Options

dom/webidl/DOMQuad.webidl

View Options

dom/webidl/DOMRect.webidl

View Options

dom/webidl/DedicatedWorkerGlobalScope.webidl

View Options

dom/webidl/DelayNode.webidl

View Options

dom/webidl/DeviceLightEvent.webidl

View Options

dom/webidl/DeviceMotionEvent.webidl

View Options

dom/webidl/DeviceOrientationEvent.webidl

View Options

dom/webidl/DeviceProximityEvent.webidl

View Options

dom/webidl/Document.webidl

View Options

dom/webidl/DocumentTimeline.webidl

View Options

dom/webidl/DragEvent.webidl

View Options

dom/webidl/DynamicsCompressorNode.webidl

View Options

dom/webidl/Element.webidl

View Options

dom/webidl/ErrorEvent.webidl

View Options

dom/webidl/Event.webidl

View Options

dom/webidl/EventSource.webidl

View Options

dom/webidl/EventTarget.webidl

View Options

dom/webidl/ExtendableEvent.webidl

View Options

dom/webidl/ExtendableMessageEvent.webidl

View Options

dom/webidl/File.webidl

View Options

dom/webidl/FileSystemDirectoryEntry.webidl

View Options

dom/webidl/FocusEvent.webidl

View Options

dom/webidl/FontFace.webidl

View Options

dom/webidl/FontFaceSetLoadEvent.webidl

View Options

dom/webidl/FrameCrashedEvent.webidl

View Options

dom/webidl/FuzzingFunctions.webidl

View Options

dom/webidl/GainNode.webidl

View Options

dom/webidl/GamepadAxisMoveEvent.webidl

View Options

dom/webidl/GamepadButtonEvent.webidl

View Options

dom/webidl/GamepadEvent.webidl

View Options

dom/webidl/Geolocation.webidl

View Options

dom/webidl/GeometryUtils.webidl

View Options

dom/webidl/HTMLInputElement.webidl

View Options

dom/webidl/HTMLSlotElement.webidl

View Options

dom/webidl/HashChangeEvent.webidl

View Options

dom/webidl/HiddenPluginEvent.webidl

View Options

dom/webidl/IDBDatabase.webidl

View Options

dom/webidl/IDBFactory.webidl

View Options

dom/webidl/IDBFileHandle.webidl

View Options

dom/webidl/IDBObjectStore.webidl

View Options

dom/webidl/IDBVersionChangeEvent.webidl

View Options

dom/webidl/ImageCaptureErrorEvent.webidl

View Options

dom/webidl/InputEvent.webidl

View Options

dom/webidl/IntersectionObserver.webidl

View Options

dom/webidl/IntlUtils.webidl

View Options

dom/webidl/KeyboardEvent.webidl

View Options

dom/webidl/KeyframeEffect.webidl

View Options

dom/webidl/MIDIConnectionEvent.webidl

View Options

dom/webidl/MIDIMessageEvent.webidl

View Options

dom/webidl/MediaDevices.webidl

View Options

dom/webidl/MediaEncryptedEvent.webidl

View Options

dom/webidl/MediaKeys.webidl

View Options

dom/webidl/MediaQueryListEvent.webidl

View Options

dom/webidl/MediaRecorder.webidl

View Options

dom/webidl/MediaStreamAudioDestinationNode.webidl

View Options

dom/webidl/MediaStreamEvent.webidl

View Options

dom/webidl/MediaStreamTrack.webidl

View Options

dom/webidl/MerchantValidationEvent.webidl

View Options

dom/webidl/MessageEvent.webidl

View Options

dom/webidl/MessagePort.webidl

View Options

dom/webidl/MouseEvent.webidl

View Options

dom/webidl/MozApplicationEvent.webidl

View Options

dom/webidl/MozFrameLoaderOwner.webidl

View Options

dom/webidl/MutationObserver.webidl

View Options

dom/webidl/Navigator.webidl

View Options

dom/webidl/Node.webidl

View Options

dom/webidl/Notification.webidl

View Options

dom/webidl/OscillatorNode.webidl

View Options

dom/webidl/PageTransitionEvent.webidl

View Options

dom/webidl/PannerNode.webidl

View Options

dom/webidl/PaymentMethodChangeEvent.webidl

View Options

dom/webidl/PaymentRequest.webidl

View Options

dom/webidl/PaymentRequestUpdateEvent.webidl

View Options

dom/webidl/PaymentResponse.webidl

View Options

dom/webidl/PeerConnectionImpl.webidl

View Options

dom/webidl/PeerConnectionObserver.webidl

View Options

dom/webidl/PerformanceEntryEvent.webidl

View Options

dom/webidl/PerformanceObserver.webidl

View Options

dom/webidl/PerformanceObserverEntryList.webidl

View Options

dom/webidl/PeriodicWave.webidl

View Options

dom/webidl/PluginCrashedEvent.webidl

View Options

dom/webidl/PointerEvent.webidl

View Options

dom/webidl/PopStateEvent.webidl

View Options

dom/webidl/PopupBlockedEvent.webidl

View Options

dom/webidl/ProgressEvent.webidl

View Options

dom/webidl/PushEvent.webidl

View Options

dom/webidl/PushManager.webidl

View Options

dom/webidl/PushSubscription.webidl

View Options

dom/webidl/RTCDTMFToneChangeEvent.webidl

View Options

dom/webidl/RTCIceCandidate.webidl

View Options

dom/webidl/RTCIdentityProvider.webidl

View Options

dom/webidl/RTCPeerConnection.webidl

View Options

dom/webidl/RTCPeerConnectionIceEvent.webidl

View Options

dom/webidl/RTCRtpSender.webidl

View Options

dom/webidl/RTCSessionDescription.webidl

View Options

dom/webidl/Reporting.webidl

View Options

dom/webidl/Request.webidl

View Options

dom/webidl/ResizeObserver.webidl

View Options

dom/webidl/Response.webidl

View Options

dom/webidl/SVGGeometryElement.webidl

View Options

dom/webidl/SVGGraphicsElement.webidl

View Options

dom/webidl/SVGTextContentElement.webidl

View Options

dom/webidl/ScrollViewChangeEvent.webidl

View Options

dom/webidl/SecurityPolicyViolationEvent.webidl

View Options

dom/webidl/ServiceWorker.webidl

View Options

dom/webidl/ServiceWorkerContainer.webidl

View Options

dom/webidl/ServiceWorkerRegistration.webidl

View Options

dom/webidl/SharedWorker.webidl

View Options

dom/webidl/SpeechRecognitionError.webidl

View Options

dom/webidl/SpeechRecognitionEvent.webidl

View Options

dom/webidl/StereoPannerNode.webidl

View Options

dom/webidl/StorageEvent.webidl

View Options

dom/webidl/StreamFilterDataEvent.webidl

View Options

dom/webidl/StyleRuleChangeEvent.webidl

View Options

dom/webidl/StyleSheetApplicableStateChangeEvent.webidl

View Options

dom/webidl/StyleSheetChangeEvent.webidl

View Options

dom/webidl/TCPServerSocket.webidl

View Options

dom/webidl/TCPServerSocketEvent.webidl

View Options

dom/webidl/TCPSocket.webidl

View Options

dom/webidl/TCPSocketErrorEvent.webidl

View Options

dom/webidl/TCPSocketEvent.webidl

View Options

dom/webidl/TestInterfaceJS.webidl

View Options

dom/webidl/TextDecoder.webidl

View Options

dom/webidl/TouchEvent.webidl

View Options

dom/webidl/TrackEvent.webidl

View Options

dom/webidl/TransitionEvent.webidl

View Options

dom/webidl/UDPMessageEvent.webidl

View Options

dom/webidl/UDPSocket.webidl

View Options

dom/webidl/UIEvent.webidl

View Options

dom/webidl/UserProximityEvent.webidl

View Options

dom/webidl/WaveShaperNode.webidl

View Options

dom/webidl/WebAuthentication.webidl

View Options

dom/webidl/WebGLContextEvent.webidl

View Options

dom/webidl/WebGPU.webidl

View Options

dom/webidl/WebrtcDeprecated.webidl

View Options

dom/webidl/WheelEvent.webidl

View Options

dom/webidl/Window.webidl

View Options

dom/webidl/WindowOrWorkerGlobalScope.webidl

View Options

dom/webidl/Worker.webidl

View Options

dom/webidl/Worklet.webidl

View Options

dom/webidl/XMLHttpRequest.webidl

View Options

dom/webidl/XULPopupElement.webidl

Privacy · Cookies · Legal