In some situations dedicated profile support does not work well. This includes a
handful of linux distributions which always install different application
versions to different locations, some application sandboxing systems as well as
enterprise deployments. This environment variable provides a way to opt out of
dedicated profiles for these cases.
Details
Details
Diff Detail
Diff Detail
- Repository
- rMOZILLACENTRAL mozilla-central
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
This change looks fine, but I am curious about the test change, and I would like to see at least some rationale for the environment variable in the commit message and/or the code itself, preferably both.
| toolkit/profile/nsToolkitProfileService.cpp | ||
|---|---|---|
| 385 | Do we want to have a separate function for checking !PR_GetEnv(...), along with some documentation about why we have legacy profile support? | |
| toolkit/profile/xpcshell/head.js | ||
| 433–438 | Wait, is this change really correct? Legacy enablement should use the snap profile? | |
| toolkit/profile/xpcshell/test_legacy_select.js | ||
| 6–7 | Nit: "...when configured" and only a single period at the end of the sentence. | |
| toolkit/profile/xpcshell/head.js | ||
|---|---|---|
| 433–438 | This new environment variable gets us into the same state as being in a snap package so the testing is just the same. I just forgot to rename the variable here as it applies more generally now. | |