Details

Reviewers

Commits

rMOZILLACENTRAL0a53924e7249: Bug 1552080 - Rejigger a bit rust features so that rusttests still link.

Bugzilla Bug ID

1552080

Summary

We cannot compile with just feature(gecko + debug_assertions), since that's how
debug rusttests get compiled and they don't have the refcount logging stuff.

We were getting away with it for the pre-existing usage of the style crate,
because it wasn't used during any test and presumably the linker didn't
complain. But servo_arc is definitely used in tests.

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

emilio created this revision.May 27 2019, 12:58 PM

Herald added a project: Restricted Project. · View Herald TranscriptMay 27 2019, 12:58 PM

Harbormaster completed remote builds in B76866: Diff 110386.May 27 2019, 12:58 PM

phab-bot requested review of this revision.May 27 2019, 12:58 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: Restricted Project.

This still doesn't seem to work on automation. :(

This works

Harbormaster completed remote builds in B77033: Diff 110600.May 27 2019, 7:48 PM

Harbormaster completed remote builds in B77033: Diff 110600.

Actually

emilio edited the summary of this revision. (Show Details)May 27 2019, 7:50 PM

Harbormaster completed remote builds in B77035: Diff 110603.May 27 2019, 7:50 PM

Harbormaster completed remote builds in B77035: Diff 110603.

chmanchester edited reviewers, added: froydnj; removed: Restricted Project.May 28 2019, 6:34 PM

froydnj accepted this revision.May 29 2019, 1:27 PM

froydnj added inline comments.

toolkit/library/rust/moz.build
19–21	Alternatively: `RUST_TEST_FEATURES = [f for f in gkrust_features if f != 'gecko_refcount_logging']` Probably could use a small comment describing why we're doing this either way.

This revision is now accepted and ready to land.May 29 2019, 1:27 PM

Add a comment

Harbormaster completed remote builds in B77922: Diff 111798.May 29 2019, 7:26 PM

emilio retitled this revision from Bug 1552080 - Regigger a bit rust features so that rusttests still link. r=#build to Bug 1552080 - Regigger a bit rust features so that rusttests still link. r=froydnj.May 29 2019, 7:26 PM

emilio edited the summary of this revision. (Show Details)

Fix speling ;)

emilio retitled this revision from Bug 1552080 - Regigger a bit rust features so that rusttests still link. r=froydnj to Bug 1552080 - Rejigger a bit rust features so that rusttests still link. r=froydnj.May 29 2019, 7:31 PM

emilio edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B77924: Diff 111809.May 29 2019, 7:31 PM

Closed by commit rMOZILLACENTRAL0a53924e7249: Bug 1552080 - Rejigger a bit rust features so that rusttests still link. (authored by emilio). · Explain WhyMay 29 2019, 7:35 PM

This revision was automatically updated to reflect the committed changes.

Bug 1552080 - Rejigger a bit rust features so that rusttests still link. r=froydnj
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 111813

servo/components/servo_arc/Cargo.toml

servo/components/servo_arc/lib.rs

servo/components/style/Cargo.toml

servo/components/style/rule_tree/mod.rs

servo/ports/geckolib/Cargo.toml

toolkit/library/gtest/rust/Cargo.toml

toolkit/library/rust/Cargo.toml

toolkit/library/rust/gkrust-features.mozbuild

toolkit/library/rust/moz.build

toolkit/library/rust/shared/Cargo.toml

Bug 1552080 - Rejigger a bit rust features so that rusttests still link. r=froydnjClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 111813

servo/components/servo_arc/Cargo.toml

servo/components/servo_arc/lib.rs

servo/components/style/Cargo.toml

servo/components/style/rule_tree/mod.rs

servo/ports/geckolib/Cargo.toml

toolkit/library/gtest/rust/Cargo.toml

toolkit/library/rust/Cargo.toml

toolkit/library/rust/gkrust-features.mozbuild

toolkit/library/rust/moz.build

toolkit/library/rust/shared/Cargo.toml

Bug 1552080 - Rejigger a bit rust features so that rusttests still link. r=froydnj
ClosedPublic
Actions

Revision Contents
Changeset List