Details
- Reviewers
birtles - Commits
- rMOZILLACENTRALc62c252bb59d: Bug 1429303 - Animate offset-rotate. r=birtles
- Bugzilla Bug ID
- 1429303
Diff Detail
- Repository
- rMOZILLACENTRAL mozilla-central
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
| layout/style/test/test_transitions_per_property.html | ||
|---|---|---|
| 331–365 | Do all these tests exist in WPT too? (We should be trying to get rid of test_transitions_per_property.html and move everything to WPT. I'm working on some changes that should hopefully help with that eventually.) | |
| 336–337 | Nit: This test could use a comment (otherwise it seems like the previous comment applies here). | |
| layout/style/test/test_transitions_per_property.html | ||
|---|---|---|
| 331–365 |
Actually, it's ok to drop all the tests related to [motion-1] from test_transitions_per_property.html directly. (I still add it because it seems we check all properties in this test file. If we forgot to add the tests of the new animatable property, we may get errors [1]). Maybe we should add a list of animatable properties which have been covered by wpt already, at least for now. | |
| layout/style/test/test_transitions_per_property.html | ||
|---|---|---|
| 331–365 | Those WPT don't seem to cover all the tests you added. Do you mind extending the WPT? | |
| layout/style/test/test_transitions_per_property.html | ||
|---|---|---|
| 331–365 | OK. I will add some in WPT. | |