Bug 1552080 - Add refcount logging to servo_arc. r=bholley,heycam
ClosedPublic
Actions

Authored by emilio on May 22 2019, 5:03 PM.

Details

Reviewers

heycam
bholley

Commits

rMOZILLACENTRAL0edd8c431471: Bug 1552080 - Add refcount logging to servo_arc. r=heycam

Bugzilla Bug ID

1552080

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

emilio created this revision.May 22 2019, 5:03 PM

Herald added a project: Restricted Project. · View Herald TranscriptMay 22 2019, 5:03 PM

Harbormaster completed remote builds in B75323: Diff 107945.May 22 2019, 5:03 PM

phab-bot requested review of this revision.May 22 2019, 5:03 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: Restricted Project.

Missed some

Harbormaster completed remote builds in B75486: Diff 108139.May 22 2019, 10:25 PM

feedback+ - generally looks good but I don't have quite the cycles for a full review today, and don't want to bottleneck this. Let me know if Cam isn't available and I can take another look at this tomorrow.

heycam accepted this revision.May 23 2019, 7:05 AM

heycam added inline comments.

layout/style/ServoStyleConstsInlines.h
118	Maybe point to the comment in servo_arc/lib.rs about why we use this name/size?
servo/components/style_traits/arc_slice.rs
78	Nit: capitalize "Arc"
85–87	Maybe add a comment that we don't bother checking for an empty `items`, since in the situations we call `from_iter_leaked` we'll always have some items?