Had to implement some OwnedSlice bits that the canvas code used.
Details
Details
Diff Detail
Diff Detail
- Repository
- rMOZILLACENTRAL mozilla-central
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
| dom/canvas/CanvasRenderingContext2D.h | ||
|---|---|---|
| 970 | You do not need the namespace prefixes here. This entire class is in the mozilla::dom namespace. | |
| layout/style/ServoStyleConstsInlines.h | ||
| 40 | It might be nice to have a 'capacity' member to help avoid unnecessary free/malloc. Maybe it's even worth checking if aOther and this have the same len it we expect that to be the case frequently enough? | |
| layout/svg/SVGObserverUtils.h | ||
| 305 | Again, we're in namespace 'mozilla'. Please remove these qualifications. | |
| 406 | ditto | |
| layout/style/ServoStyleConstsInlines.h | ||
|---|---|---|
| 40 | Yeah, this is not what this class is about though, this is not a growable list so we can't take a capacity. But most times the source list would be empty since this will be called from the copy constructor. | |