Page MenuHomePhabricator

Bug 1353680, test the linter on phabricator, r=flod
AbandonedPublic

Authored by Pike on Apr 26 2019, 3:36 PM.

Details

Reviewers
flod
Bugzilla Bug ID
1353680
Summary

Depends on D20465

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Branch
default
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.

Code analysis found 2 defects in this patch:

  • 2 defects found by mozlint

You can run this analysis locally with:

  • ./mach lint --warnings path/to/file (JS/Python/etc)

If you see a problem in this automated review, please report it here.

browser/locales/en-US/browser/preferences/blocklists.ftl
36

Error: Unparsed content "blocklist-item-moz-full-listName = Level 2 block }list." from line 36 column 1 to line 36 column 56 [l10n]

toolkit/locales/en-US/toolkit/about/aboutAddons.ftl
5

Warning: Changes to string require a new ID: shortcuts-empty-message [l10n]

Not sure I'm supposed to review this, but the warnings look definitely good.

This revision is now accepted and ready to land.Apr 29 2019, 8:40 AM

Thanks for checking that this works as intended. Abandoning as it served its purpose.