Details

Reviewers

Commits

rMOZILLACENTRAL6354ee4fbdc3: Bug 1951697 - Add missing include for MOZ_RUNINIT r=gerard-majax
rMOZILLACENTRAL45979a46e612: Bug 1951697 - Add missing include for MOZ_RUNINIT r=gerard-majax

Bugzilla Bug ID

1951697

Diff Detail

Repository: rMOZILLACENTRAL mozilla-central

Event Timeline

sergesanspaille created this revision.Mar 5 2025, 4:23 PM

Herald added a project: secure-revision. · View Herald TranscriptMar 5 2025, 4:23 PM

phab-bot published this revision for review.Mar 5 2025, 4:23 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Harbormaster completed remote builds in B762835: Diff 994714.Mar 5 2025, 4:49 PM

Let's just make sure we update the git author to reflect the contributor's patch

This revision is now accepted and ready to land.Mar 5 2025, 7:46 PM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

sergesanspaille updated this revision to Diff 994982.Mar 5 2025, 10:32 PM

sergesanspaille retitled this revision from Bug 1951697 - Add missing include for MOZ_RUNINIT r=gerard-majax to Bug 1951697 - Add missing include for MOZ_RUNINIT r=gerard-majax!.

Harbormaster completed remote builds in B762998: Diff 994982.Mar 5 2025, 11:10 PM

gerard-majax edited projects, added testing-exception-unchanged (Doesn't change behavior for users); removed needs-testing-tag.Mar 6 2025, 6:02 AM

Closed by commit rMOZILLACENTRAL45979a46e612: Bug 1951697 - Add missing include for MOZ_RUNINIT r=gerard-majax (authored by elsandosgrande). · Explain WhyMar 6 2025, 6:08 AM

This revision was automatically updated to reflect the committed changes.

elsandosgrande added a commit: rMOZILLACENTRAL45979a46e612: Bug 1951697 - Add missing include for MOZ_RUNINIT r=gerard-majax.

abutkovits reopened this revision.Mar 6 2025, 7:25 AM

This revision is now accepted and ready to land.Mar 6 2025, 7:25 AM

abutkovits added a reverting change: rMOZILLACENTRAL29ca7ddfb776: Backed out changeset 45979a46e612 (bug 1951697) for causing bustages….Mar 6 2025, 7:25 AM

My apologies if I'm overstepping my bounds by commenting here, but may I ask why the filename was used instead of the inclname, which I used in my patch as attached over on Bugzilla? Between https://github.com/mozilla/gecko-dev/blob/d5cbb5b26c2fe8639da9ea0b0f225018d3697c59/config/check_spidermonkey_style.py#L294 and https://github.com/mozilla/gecko-dev/blob/d5cbb5b26c2fe8639da9ea0b0f225018d3697c59/docs/code-quality/coding-style/using_cxx_in_firefox_code.rst#notes, it seems to me that mozilla/Attributes.h is the correct include path; Firefox builds fine on my laptop when using mozilla/Attributes.h instead of mfbt/Attributes.h at the very least. I also searched for both mozilla/Attributes.h and mfbt/Attributes.h on GitHub and only got include results when searching for the former.

sergesanspaille updated this revision to Diff 995866.Mar 7 2025, 7:49 AM

In D240500#8311085, @elsandosgrande wrote:

My apologies if I'm overstepping my bounds by commenting here, but may I ask why the filename was used instead of the inclname, which I used in my patch as attached over on Bugzilla? Between https://github.com/mozilla/gecko-dev/blob/d5cbb5b26c2fe8639da9ea0b0f225018d3697c59/config/check_spidermonkey_style.py#L294 and https://github.com/mozilla/gecko-dev/blob/d5cbb5b26c2fe8639da9ea0b0f225018d3697c59/docs/code-quality/coding-style/using_cxx_in_firefox_code.rst#notes, it seems to me that mozilla/Attributes.h is the correct include path; Firefox builds fine on my laptop when using mozilla/Attributes.h instead of mfbt/Attributes.h at the very least. I also searched for both mozilla/Attributes.h and mfbt/Attributes.h on GitHub and only got include results when searching for the former.

No offense meant, your comment is pin-point correct. I actually wrote the patch independently from yours then saw you wrote one and didn't double check when attributing. Patch updated, I'll land that this morning.
Apologizes and thanks :-)

Harbormaster completed remote builds in B763635: Diff 995866.Mar 7 2025, 8:22 AM

Closed by commit rMOZILLACENTRAL6354ee4fbdc3: Bug 1951697 - Add missing include for MOZ_RUNINIT r=gerard-majax (authored by elsandosgrande). · Explain WhyMar 7 2025, 8:40 AM

This revision was automatically updated to reflect the committed changes.

elsandosgrande added a commit: rMOZILLACENTRAL6354ee4fbdc3: Bug 1951697 - Add missing include for MOZ_RUNINIT r=gerard-majax.