Page MenuHomePhabricator
Differential D237702

Bug 1790526 - Handle the discarded BrowsingContext that propagated to SessionStoreParent. r=smaug
ClosedPublic
Actions

Authored by edenchuang on Feb 11 2025, 11:37 AM.
Tags
Referenced Files
Unknown Object (File)
Thu, Oct 16, 2:25 PM
Unknown Object (File)
Tue, Oct 14, 1:31 AM
Unknown Object (File)
Tue, Oct 7, 10:24 AM
Unknown Object (File)
Tue, Sep 23, 7:18 AM
Unknown Object (File)
Sep 16 2025, 9:58 PM
Unknown Object (File)
Aug 2 2025, 1:33 AM
Unknown Object (File)
Jun 25 2025, 9:42 AM
Unknown Object (File)
May 30 2025, 12:30 PM
View All 18 Files
Subscribers
thesamesam

Details

Reviewers
smaug
Commits
rMOZILLACENTRAL4159736c2897: Bug 1790526 - Handle the discarded BrowsingContext that propagated to…
rMOZILLACENTRALbd801b491ec6: Bug 1790526 - Check if the propagated BrowsingContext is discarded or not in…
Bugzilla Bug ID
1790526
Summary

According to the Pernosco trace, https://static.pernos.co/server/7c640bc4ed587e824fab0ca8aa44f41d1b5595b5/rebuilding.html?redirect=https%3A%2F%2Fpernos.co%2Fdebug%2FAKTDVC62g_oHMo8GmtoA1g%2Findex.html, this is a case that the propagated BrowingContext has been discarded already, so it causes aBrowsingContext.GetMaybeDiscarded() get a nullptr.

This patch just check if the propageted BrowsingContext is discarded.
For the discarded BrowsingContext, try to use its BrowsingContextId to get the corresponding CanonicalBrowsingContext instead of using the propagated one.

Diff Detail

Event Timeline

edenchuang created this revision.Feb 11 2025, 11:37 AM
Herald added a project: secure-revision. · View Herald TranscriptFeb 11 2025, 11:37 AM
Harbormaster completed remote builds in B753643: Diff 982650.Feb 11 2025, 11:38 AM
phab-bot published this revision for review.Feb 11 2025, 11:38 AM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Herald added a reviewer: core-sessionstore-reviewers. · View Herald TranscriptFeb 11 2025, 11:38 AM
peterv requested changes to this revision.Feb 12 2025, 4:02 PM
peterv added inline comments.
toolkit/components/sessionstore/SessionStoreParent.cpp
201–213

I'd rather do this instead.

229
This revision now requires changes to proceed.Feb 12 2025, 4:02 PM
edenchuang requested review of this revision.Feb 25 2025, 9:07 AM
edenchuang updated this revision to Diff 990108.
edenchuang edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B759191: Diff 990108.Feb 25 2025, 9:07 AM
thesamesam added a subscriber: thesamesam.Mar 2 2025, 5:18 PM
thesamesam added a comment.Mar 3 2025, 10:32 AM

This solves a crash I've been seeing with LTO as well (https://bugzilla.mozilla.org/show_bug.cgi?id=1790526#c12).

edenchuang added a reviewer: smaug.Mar 11 2025, 2:28 PM
smaug accepted this revision.Mar 11 2025, 8:57 PM
edenchuang removed a reviewer: peterv.Mar 13 2025, 10:55 AM
edenchuang added a reviewer: farre.Mar 13 2025, 10:57 AM
edenchuang removed reviewers: core-sessionstore-reviewers, farre.Mar 17 2025, 10:02 AM
This revision is now accepted and ready to land.Mar 17 2025, 10:02 AM
Herald added a project: needs-testing-tag. · View Herald TranscriptMar 17 2025, 10:02 AM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

edenchuang edited projects, added testing-exception-unchanged (Doesn't change behavior for users); removed needs-testing-tag.Mar 17 2025, 10:04 AM
Closed by commit rMOZILLACENTRALbd801b491ec6: Bug 1790526 - Check if the propagated BrowsingContext is discarded or not in… (authored by edenchuang). · Explain WhyMar 17 2025, 10:10 AM
This revision was automatically updated to reflect the committed changes.
edenchuang added a commit: rMOZILLACENTRALbd801b491ec6: Bug 1790526 - Check if the propagated BrowsingContext is discarded or not in….
sstanca reopened this revision.Mar 17 2025, 11:22 AM
This revision is now accepted and ready to land.Mar 17 2025, 11:22 AM
sstanca added a reverting change: rMOZILLACENTRALb91c43d05d95: Backed out changeset bd801b491ec6 (bug 1790526) for causing mochitests failures….Mar 17 2025, 11:22 AM
edenchuang updated this revision to Diff 1012597.Apr 8 2025, 2:15 PM
edenchuang retitled this revision from Bug 1790526 - Check if the propagated BrowsingContext is discarded or not in SessionStoreParent. r=peterv to Bug 1790526 - Handle the discarded BrowsingContext that propagated to SessionStoreParent. r=smaug.
edenchuang edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B776127: Diff 1012597.Apr 8 2025, 2:34 PM
Closed by commit rMOZILLACENTRAL4159736c2897: Bug 1790526 - Handle the discarded BrowsingContext that propagated to… (authored by edenchuang). · Explain WhyApr 8 2025, 6:50 PM
This revision was automatically updated to reflect the committed changes.
edenchuang added a commit: rMOZILLACENTRAL4159736c2897: Bug 1790526 - Handle the discarded BrowsingContext that propagated to….

Revision Contents
Changeset List

PathSize
toolkit/
components/
sessionstore/
31 lines

Diff 1012793

View Options

toolkit/components/sessionstore/SessionStoreParent.cpp

Loading...
Privacy · Cookies · Legal