Differential D221744

Bug 1917964 - Fix swgl build with GCC 15. r?lsalzman
ClosedPublic
Actions

Authored by thesamesam on Sep 10 2024, 11:08 PM.

Details

Reviewers

lsalzman

Group Reviewers

gfx-reviewers

Commits

rMOZILLACENTRAL0249085453e0: Bug 1917964 - Fix swgl build with GCC 15. r=gfx-reviewers,lsalzman

Bugzilla Bug ID

1917964

Summary

Fix broken specialisations which are exposed by a recent change in GCC trunk.

See https://gcc.gnu.org/PR116666.

Diff Detail

Repository: rMOZILLACENTRAL mozilla-central

Event Timeline

thesamesam created this revision.Sep 10 2024, 11:08 PM

Herald added a project: secure-revision. · View Herald TranscriptSep 10 2024, 11:08 PM

Harbormaster completed remote builds in B700529: Diff 912089.Sep 10 2024, 11:08 PM

phab-bot published this revision for review.Sep 10 2024, 11:08 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Sorry, I'm not sure who a suitable reviewer is, so I picked the poor guy who tends to handle compiler-related issues we report.

glandium edited reviewers, added: gfx-reviewers; removed: glandium.Sep 10 2024, 11:52 PM

lsalzman accepted this revision.Sep 11 2024, 2:10 AM

This revision is now accepted and ready to land.Sep 11 2024, 2:10 AM

lsalzman added a project: testing-exception-unchanged (Doesn't change behavior for users).Sep 11 2024, 2:10 AM

Thanks! What do I need to do to land it?

lsalzman updated this revision to Diff 912695.Sep 11 2024, 7:03 PM

lsalzman retitled this revision from Bug 1917964 - Fix swgl build with GCC 15. r?glandium to Bug 1917964 - Fix swgl build with GCC 15. r?lsalzman.

lsalzman edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B701055: Diff 912695.Sep 11 2024, 7:03 PM

Closed by commit rMOZILLACENTRAL0249085453e0: Bug 1917964 - Fix swgl build with GCC 15. r=gfx-reviewers,lsalzman (authored by thesamesam). · Explain WhySep 11 2024, 8:36 PM

This revision was automatically updated to reflect the committed changes.

thesamesam added a commit: rMOZILLACENTRAL0249085453e0: Bug 1917964 - Fix swgl build with GCC 15. r=gfx-reviewers,lsalzman.

Revision Contents
Changeset List

Path

Size

gfx/

wr/

swgl/

src/

vector_type.h

24 lines

Diff 912746

View Options

gfx/wr/swgl/src/vector_type.h

Bug 1917964 - Fix swgl build with GCC 15. r?lsalzmanClosedPublicActions