Differential D219224

Bug 1913286 - WebRTC backport: PipeWire camera: filter out devices with no capabilities r=pehrsons
ClosedPublic
Actions

Authored by grulja on Aug 15 2024, 10:03 AM.

Details

Reviewers

pehrsons

Group Reviewers

webrtc-reviewers

Commits

rMOZILLACENTRAL25415f3c3440: Bug 1913286 - WebRTC backport: PipeWire camera: filter out devices with no…

Bugzilla Bug ID

1913286

Summary

Filter out devices that do not support any format supported by WebRTC.
This will for example be IR cameras that show as duplicated in the list
of cameras, but support only GRAY8 format and for that reason do not
work at all.

This is a simple backport of an WebRTC upstream change.

Upstream commit: b4aba7834e6c94adace1cb4c20e2e1ee70eb9cc5

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Build Status

Buildable 697630
Build 797156: arc lint + arc unit

Event Timeline

grulja created this revision.Aug 15 2024, 10:03 AM

Herald added a project: secure-revision. · View Herald TranscriptAug 15 2024, 10:03 AM

Harbormaster completed remote builds in B692547: Diff 902289.Aug 15 2024, 10:03 AM

phab-bot published this revision for review.Aug 15 2024, 10:03 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a reviewer: webrtc-reviewers. · View Herald TranscriptAug 15 2024, 10:03 AM

Code analysis found 2 defects in diff 902289:

2 defects found by code coverage analysis

WARNING: Found 2 defects (warning level) that can be dismissed.

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 902289.