Differential D207197

Bug 1890593 - GetSystemWPADSetting for libproxy-enabled builds
ClosedPublic
Actions

Authored by cmt on Apr 10 2024, 7:50 PM.

Tags

Referenced Files

	Unknown Object (File)
	Thu, Oct 16, 10:13 AM

	Unknown Object (File)
	May 13 2025, 5:36 PM

	Unknown Object (File)
	Jan 10 2025, 9:40 PM

	Unknown Object (File)
	Jan 4 2025, 7:23 AM

	Unknown Object (File)
	Dec 25 2024, 1:28 AM

	Unknown Object (File)
	Dec 6 2024, 1:24 PM

	Unknown Object (File)
	Nov 30 2024, 11:49 PM

	Unknown Object (File)
	Nov 21 2024, 5:06 PM

View All 32 Files

Subscribers

None

Details

Reviewers

Commits

rMOZILLACENTRAL15006906e885: Bug 1890593 - GetSystemWPADSetting for libproxy-enabled builds r=jesup

Bugzilla Bug ID

Summary

In #621429 a call to nsUnixSystemProxySettings::GetSystemWPADSetting()
was added, but that function is not available for builds with
MOZ_ENABLE_LIBPROXY. The funtion is trivial enough to just
copy it across - else there'd more boilerplate than actual code.

Diff Detail

Repository: rMOZILLACENTRAL mozilla-central

Event Timeline

cmt created this revision.Apr 10 2024, 7:50 PM

Herald added a project: secure-revision. · View Herald TranscriptApr 10 2024, 7:50 PM

Harbormaster completed remote builds in B648331: Diff 847808.Apr 10 2024, 7:50 PM

phab-bot published this revision for review.Apr 10 2024, 7:50 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

jesup accepted this revision.Apr 10 2024, 9:04 PM

jesup added a project: testing-exception-unchanged (Doesn't change behavior for users).

This revision is now accepted and ready to land.Apr 10 2024, 9:04 PM

Closed by commit rMOZILLACENTRAL15006906e885: Bug 1890593 - GetSystemWPADSetting for libproxy-enabled builds r=jesup (authored by cmt). · Explain WhyApr 10 2024, 9:10 PM

This revision was automatically updated to reflect the committed changes.

cmt added a commit: rMOZILLACENTRAL15006906e885: Bug 1890593 - GetSystemWPADSetting for libproxy-enabled builds r=jesup.

Revision Contents
Changeset List

Path

Size

toolkit/

system/

unixproxy/

nsLibProxySettings.cpp

6 lines

Diff 847839

toolkit/system/unixproxy/nsLibProxySettings.cpp

Loading...