Details
- Reviewers
glandium - Group Reviewers
Restricted Project - Commits
- rMOZILLACENTRAL1db2ef126a6a: Bug 1882209 - Update encoding_rs to 0.8.34 to deal with rustc changes.
rMOZILLACENTRAL05cb55554fc0: Bug 1882209 - Update encoding_rs to 0.8.34 to deal with rustc changes. - Bugzilla Bug ID
- 1882209
Diff Detail
- Repository
- rMOZILLACENTRAL mozilla-central
- Build Status
Buildable 655394 Build 754277: arc lint + arc unit
Event Timeline
This most certainly requires changes to:
- https://searchfox.org/mozilla-central/rev/1f27a4022f9f1269d897526c1c892a57743e650c/config/makefiles/rust.mk#268
- https://searchfox.org/mozilla-central/rev/1f27a4022f9f1269d897526c1c892a57743e650c/python/mozboot/mozboot/util.py#14
- https://searchfox.org/mozilla-central/rev/1f27a4022f9f1269d897526c1c892a57743e650c/taskcluster/ci/toolchain/rust.yml#14-27
I was expecting you to do the MSRV bump and land this change along with it. I'll update the bootstap bit here, though.
| supply-chain/audits.toml | ||
|---|---|---|
| 4–11 | Is this crate one where you'd expect to have multiple versions? It seems like a one-off crate, which might make more sense to audit with a normal one-off version audit, rather than adding a blanket audit for you to publish more versions going forward. | |
| supply-chain/audits.toml | ||
|---|---|---|
| 4–11 | Changed to non-wildcard. | |
This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!
| supply-chain/audits.toml | ||
|---|---|---|
| 615 | I'm confused. You are upstream. Why not publish a new version and import it? | |
| supply-chain/audits.toml | ||
|---|---|---|
| 615 | Last time I had a build.rs hack on crates.io, people got upset (though, arguably, it was more of a hack than this). | |
| supply-chain/audits.toml | ||
|---|---|---|
| 615 | Landed per out-of-band discussion. | |