Page MenuHomePhabricator
Differential D207004

Bug 1889054 - Fix issues with non-unified builds missing header inclusions. r?#build
ClosedPublic
Actions

Authored by amit.prakash.ambasta on Apr 9 2024, 11:44 AM.
Tags
Referenced Files
Unknown Object (File)
Mar 15 2025, 9:52 AM
Unknown Object (File)
Jan 4 2025, 12:59 AM
Unknown Object (File)
Jan 1 2025, 5:58 AM
Unknown Object (File)
Dec 30 2024, 12:07 AM
Unknown Object (File)
Dec 29 2024, 9:20 AM
Unknown Object (File)
May 28 2024, 9:01 AM
Subscribers
emilio

Details

Reviewers
emilio
Group Reviewers
Restricted Project
Commits
rMOZILLACENTRAL2fc58e526510: Bug 1889054 - Fix issues with non-unified builds missing header inclusions.
Bugzilla Bug ID
1889054
Summary

Signed-off-by: Amit Prakash Ambasta <amit.prakash.ambasta@gmail.com>

Diff Detail

Event Timeline

amit.prakash.ambasta created this revision.Apr 9 2024, 11:44 AM
Herald added a project: secure-revision. · View Herald TranscriptApr 9 2024, 11:44 AM
Harbormaster completed remote builds in B647582: Diff 846931.Apr 9 2024, 11:44 AM
phab-bot published this revision for review.Apr 9 2024, 11:44 AM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Herald added a subscriber: emilio. · View Herald TranscriptApr 9 2024, 11:44 AM
emilio requested changes to this revision.Apr 9 2024, 11:48 AM
emilio added a project: testing-exception-unchanged (Doesn't change behavior for users).
emilio added inline comments.
widget/gtk/GtkCompositorWidget.h
11 ↗(On Diff #846931)

Why is this one needed? This should go in the cpp file, not in the header, if the issue is:

Missing header for GdkIsWaylandDisplay in widget/gtk/GtkCompositorWidget.cpp

This revision now requires changes to proceed.Apr 9 2024, 11:48 AM
amit.prakash.ambasta requested review of this revision.Apr 9 2024, 11:48 AM

Please review!

amit.prakash.ambasta updated this revision to Diff 846934.Apr 9 2024, 12:02 PM
Harbormaster completed remote builds in B647584: Diff 846934.Apr 9 2024, 12:02 PM
amit.prakash.ambasta added inline comments.Apr 9 2024, 12:04 PM
widget/gtk/GtkCompositorWidget.h
11 ↗(On Diff #846931)

Moved as suggested. And yes, GtkCompositorWidget.cpp is the one that needed the header.

emilio accepted this revision.Apr 9 2024, 12:09 PM
This revision is now accepted and ready to land.Apr 9 2024, 12:09 PM
Closed by commit rMOZILLACENTRAL2fc58e526510: Bug 1889054 - Fix issues with non-unified builds missing header inclusions. (authored by amit.prakash.ambasta). · Explain WhyApr 9 2024, 12:16 PM
This revision was automatically updated to reflect the committed changes.
amit.prakash.ambasta added a commit: rMOZILLACENTRAL2fc58e526510: Bug 1889054 - Fix issues with non-unified builds missing header inclusions..

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
accessible/
html/
1 line89%
Loading...
1 line95%
Loading...
intl/
components/
src/
1 line93%
Loading...
widget/
gtk/
1 line68%
Loading...

Diff 846952

View Options

accessible/html/HTMLSelectAccessible.cpp

Loading...
View Options

accessible/html/HTMLTableAccessible.cpp

Loading...
View Options

intl/components/src/TimeZone.h

Loading...
View Options

widget/gtk/GtkCompositorWidget.cpp

Loading...
Privacy · Cookies · Legal