Page MenuHomePhabricator
Differential D197508

Bug 1793001 - s/egrep/grep -E/ r=ahochheiden
ClosedPublic
Actions

Authored by sergesanspaille on Jan 2 2024, 1:44 PM.
Tags
Referenced Files
Unknown Object (File)
Wed, Oct 15, 7:11 AM
Unknown Object (File)
Wed, Oct 15, 4:33 AM
Unknown Object (File)
Mon, Oct 13, 4:05 PM
Unknown Object (File)
May 14 2024, 1:37 AM
Unknown Object (File)
Feb 5 2024, 10:58 AM
Subscribers
None

Details

Reviewers
ahochheiden
Commits
rMOZILLACENTRALfba2b83c6fe0: Bug 1793001 - s/egrep/grep -E/ r=ahochheiden
Bugzilla Bug ID
1793001

Diff Detail

Event Timeline

sergesanspaille created this revision.Jan 2 2024, 1:44 PM
Herald added a project: secure-revision. · View Herald TranscriptJan 2 2024, 1:44 PM
Harbormaster completed remote builds in B612279: Diff 804895.Jan 2 2024, 1:44 PM
phab-bot published this revision for review.Jan 2 2024, 1:44 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
sergesanspaille updated this revision to Diff 804896.Jan 2 2024, 1:46 PM
Harbormaster completed remote builds in B612282: Diff 804896.Jan 2 2024, 1:46 PM
ahochheiden requested changes to this revision.Jan 4 2024, 7:49 PM

It seems there are additional uses of egrep in nsprpub/configure.in that we should also change.

This revision now requires changes to proceed.Jan 4 2024, 7:49 PM
sergesanspaille added a comment.Jan 10 2024, 7:17 AM
In D197508#6786943, @ahochheiden wrote:

It seems there are additional uses of egrep in nsprpub/configure.in that we should also change.

nsprpub is a third-party project :-/

ahochheiden accepted this revision.Jan 16 2024, 5:53 PM
ahochheiden added a project: testing-exception-unchanged (Doesn't change behavior for users).
In D197508#6799873, @sergesanspaille wrote:
In D197508#6786943, @ahochheiden wrote:

It seems there are additional uses of egrep in nsprpub/configure.in that we should also change.

nsprpub is a third-party project :-/

Ah, my mistake. Proceed!

This revision is now accepted and ready to land.Jan 16 2024, 5:53 PM
Closed by commit rMOZILLACENTRALfba2b83c6fe0: Bug 1793001 - s/egrep/grep -E/ r=ahochheiden (authored by sergesanspaille). · Explain WhyJan 17 2024, 2:42 PM
This revision was automatically updated to reflect the committed changes.
sergesanspaille added a commit: rMOZILLACENTRALfba2b83c6fe0: Bug 1793001 - s/egrep/grep -E/ r=ahochheiden.

Revision Contents
Changeset List

PathSize
build/
autoconf/
2 lines
6 lines
js/
src/
4 lines
4 lines

Diff 810113

View Options

build/autoconf/acgeneral.m4

Loading...
View Options

build/autoconf/acspecific.m4

Loading...
View Options

js/src/old-configure.in

Loading...
View Options

old-configure.in

Loading...
Privacy · Cookies · Legal