Page MenuHomePhabricator

Bug 1743144 [Wayland] Enable Wayland proxy on start r?emilio
ClosedPublic

Authored by stransky on Dec 15 2023, 1:56 PM.
Referenced Files
Unknown Object (File)
Sat, Oct 18, 9:36 AM
Unknown Object (File)
Thu, Oct 16, 2:21 PM
Unknown Object (File)
Tue, Oct 14, 10:41 PM
Unknown Object (File)
Mon, Oct 13, 8:27 PM
Unknown Object (File)
Thu, Oct 2, 4:05 AM
Unknown Object (File)
Aug 6 2025, 12:30 AM
Unknown Object (File)
Aug 6 2025, 12:30 AM
Unknown Object (File)
Aug 5 2025, 12:09 PM
Subscribers

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
stransky edited the summary of this revision. (Show Details)

LGTM!

toolkit/xre/nsAppRunner.cpp
5998

No reason for the if here.

testing-exception-other: This is an issue that we can't realistically test for. We should see declining crash rates as a result of this work tho.

toolkit/xre/nsAppRunner.cpp
4735

Not sure the XRE_IsParentProcess check is needed. Don't content processes use the IsHeadless codepath?

5998

Agreed.

This revision is now accepted and ready to land.Dec 15 2023, 2:43 PM
stransky marked 3 inline comments as done.

Code analysis found 1 defect in diff 803050:

  • 1 defect found by py-black (Mozlint)
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 803050.