Page MenuHomePhabricator
Differential D196555

Bug 1743144 [Wayland] Enable Wayland proxy on start r?emilio
ClosedPublic
Actions

Authored by stransky on Dec 15 2023, 1:56 PM.
Tags
Referenced Files
Unknown Object (File)
Sat, Oct 18, 9:36 AM
Unknown Object (File)
Thu, Oct 16, 2:21 PM
Unknown Object (File)
Tue, Oct 14, 10:41 PM
Unknown Object (File)
Mon, Oct 13, 8:27 PM
Unknown Object (File)
Thu, Oct 2, 4:05 AM
Unknown Object (File)
Aug 6 2025, 12:30 AM
Unknown Object (File)
Aug 6 2025, 12:30 AM
Unknown Object (File)
Aug 5 2025, 12:09 PM
View All 71 Files
Subscribers
reviewbot
rmader

Details

Reviewers
emilio
Commits
rMOZILLACENTRALb0d2efdcd6cc: Bug 1743144 [Wayland] Enable Wayland proxy on start r=emilio
Bugzilla Bug ID
1743144

Diff Detail

Event Timeline

stransky created this revision.Dec 15 2023, 1:56 PM
Herald added a project: secure-revision. · View Herald TranscriptDec 15 2023, 1:56 PM
Harbormaster completed remote builds in B608447: Diff 800506.Dec 15 2023, 1:56 PM
stransky added a child revision: D196556: Bug 1743144 [Wayland] Add disable/enable wayland-proxy build option and enabled it on Wayland by default r?glandium.Dec 15 2023, 1:56 PM
phab-bot published this revision for review.Dec 15 2023, 2:15 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
stransky updated this revision to Diff 800519.Dec 15 2023, 2:19 PM
stransky edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B608459: Diff 800519.Dec 15 2023, 2:19 PM
rmader added a subscriber: rmader.Dec 15 2023, 2:25 PM

LGTM!

toolkit/xre/nsAppRunner.cpp
5998

No reason for the if here.

emilio accepted this revision.Dec 15 2023, 2:43 PM
emilio added a project: testing-exception-other (Please leave a comment explaining why) .

testing-exception-other: This is an issue that we can't realistically test for. We should see declining crash rates as a result of this work tho.

toolkit/xre/nsAppRunner.cpp
4735

Not sure the XRE_IsParentProcess check is needed. Don't content processes use the IsHeadless codepath?

5998

Agreed.

This revision is now accepted and ready to land.Dec 15 2023, 2:43 PM
stransky updated this revision to Diff 801163.Dec 18 2023, 11:46 AM
Harbormaster completed remote builds in B609045: Diff 801163.Dec 18 2023, 11:46 AM
stransky updated this revision to Diff 801718.Dec 19 2023, 8:48 AM
Harbormaster completed remote builds in B609454: Diff 801718.Dec 19 2023, 8:48 AM
stransky updated this revision to Diff 802963.Dec 21 2023, 9:35 AM
Harbormaster completed remote builds in B610623: Diff 802963.Dec 21 2023, 9:35 AM
stransky updated this revision to Diff 803050.Dec 21 2023, 11:39 AM
stransky marked 3 inline comments as done.
Harbormaster completed remote builds in B610706: Diff 803050.Dec 21 2023, 11:39 AM
reviewbot added a subscriber: reviewbot.Dec 21 2023, 12:22 PM

Code analysis found 1 defect in diff 803050:

  • 1 defect found by py-black (Mozlint)
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 803050.

stransky updated this revision to Diff 804901.Jan 2 2024, 2:00 PM
Harbormaster completed remote builds in B612287: Diff 804901.Jan 2 2024, 2:00 PM
stransky updated this revision to Diff 805651.Jan 4 2024, 2:08 PM
Harbormaster completed remote builds in B612931: Diff 805651.Jan 4 2024, 2:08 PM
stransky updated this revision to Diff 805658.Jan 4 2024, 2:21 PM
Harbormaster completed remote builds in B612937: Diff 805658.Jan 4 2024, 2:22 PM
stransky updated this revision to Diff 807070.Jan 9 2024, 12:23 PM
Harbormaster completed remote builds in B614122: Diff 807070.Jan 9 2024, 12:23 PM
Closed by commit rMOZILLACENTRALb0d2efdcd6cc: Bug 1743144 [Wayland] Enable Wayland proxy on start r=emilio (authored by stransky). · Explain WhyJan 9 2024, 12:37 PM
This revision was automatically updated to reflect the committed changes.
stransky added a commit: rMOZILLACENTRALb0d2efdcd6cc: Bug 1743144 [Wayland] Enable Wayland proxy on start r=emilio.
Harbormaster completed remote builds in B614463: Diff 807073.Jan 30 2024, 6:06 PM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
toolkit/
xre/
36 lines62%
Loading...

Diff 807073

View Options

toolkit/xre/nsAppRunner.cpp

Loading...
Privacy · Cookies · Legal