WR draw image tiles as segments
ClosedPublic
Actions

Authored by kvark on Feb 12 2019, 2:49 AM.

Details

Reviewers

gw
nical

Commits

Restricted Diffusion Commit
rMOZILLACENTRALe4db508a2d78: Bug 1526235 - WR draw image tiles as segments r=gw,nical

Bugzilla Bug ID

1526235

Summary

We are currently drawing tiles as separate primitives. This doesn't work well for
masking out edge AA between tiles, since they aren't aware of each other.

The change switches image tiles to be drawn as segments sharing the same header.

Test Plan

try https://treeherder.mozilla.org/#/jobs?repo=try&revision=25d3ada065fe047ceca59c1601ba894ba3b3c196

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Build Status

Buildable 39991
Build 51004: arc lint + arc unit

Event Timeline

kvark created this revision.Feb 12 2019, 2:49 AM

Herald added a project: Restricted Project. · View Herald TranscriptFeb 12 2019, 2:49 AM

Harbormaster completed remote builds in B39412: Diff 60940.Feb 12 2019, 2:49 AM

phab-bot requested review of this revision.Feb 12 2019, 2:49 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: Restricted Project.

gw accepted this revision.Feb 12 2019, 3:31 AM

gw added inline comments.

gfx/wr/webrender/src/batch.rs
1910	Use PremultipledColorF::WHITE here?
gfx/wr/webrender/src/prim_store/mod.rs
2727	I think this piece / gpu cache handle can completely disappear, once rebased on my change, is that right?

This revision is now accepted and ready to land.Feb 12 2019, 3:31 AM

nical accepted this revision.Feb 12 2019, 8:51 AM

nical added inline comments.

gfx/wr/webrender/src/prim_store/mod.rs
2744	Looks like a good occasion to update this comment which refers to the `visible_rect: Option<LayoutRect>` we used to have here instead of `visibility_info`. No need to go in much detail about why we set some rect to None anymore.