Differential D19254

WR: rework the relative transform query on a clip-scroll tree
ClosedPublic
Actions

Authored by kvark on Feb 9 2019, 2:24 AM.

Details

Reviewers

Commits

Restricted Diffusion Commit
rMOZILLACENTRAL87dac4d84c6b: Bug 1524797 - WR: rework the relative transform query on a clip-scroll tree r=gw

Bugzilla Bug ID

1524797

Summary

This change rewords get_relative_transform and assotiated pieces of logic,
so that we flatten the transforms at preserve-3d context boundaries.

It addresses a problem found by 1524797 but doesn't resolve the bug yet (!).
There is another issue likely contributing here, and we can treat this PR
as WIP and not merge until the case is completely resolved.

Test Plan

new reftest is added to wrench at transforms/flatten-preserve-3d-root
Gecko try https://treeherder.mozilla.org/#/jobs?repo=try&revision=2cf54c03a9e1751e5aa62f44d0c6bbb7b714a6a6

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Build Status

Buildable 39988
Build 51001: arc lint + arc unit

Event Timeline

kvark created this revision.Feb 9 2019, 2:24 AM

Herald added a project: Restricted Project. · View Herald TranscriptFeb 9 2019, 2:24 AM

Harbormaster completed remote builds in B38933: Diff 60321.Feb 9 2019, 2:24 AM

phab-bot requested review of this revision.Feb 9 2019, 2:24 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: Restricted Project.

This should be ready to land independently. The other problem in http://impress.js.org/ is fixed by https://phabricator.services.mozilla.com/D19384

Do we need a try / talos just to confirm it doesn't regress perf?

This revision is now accepted and ready to land.Feb 11 2019, 7:58 PM

The try shows 18% regression on "perf_reftest opt e10s stylo", trying to figure out what this test is...

Looking at the latest try from rebased code, the regression is gone: https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=227793031&revision=a3b4ec622a5d648e30d6d1105891109915839980

Closed by commit rMOZILLACENTRAL87dac4d84c6b: Bug 1524797 - WR: rework the relative transform query on a clip-scroll tree r=gw (authored by kvark). · Explain WhyFeb 12 2019, 3:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

gfx/

wr/

webrender/

src/

clip.rs

4 lines

29%

clip_scroll_tree.rs

139 lines

gpu_types.rs

27 lines

picture.rs

56 lines

prim_store/

mod.rs

69 lines

spatial_node.rs

4 lines

14%

util.rs

47 lines

13%

wrench/

reftests/

transforms/

content-offset.yaml

1 line

flatten-preserve-3d-root-ref.yaml

6 lines

flatten-preserve-3d-root.yaml

23 lines

reftest.list

1 line

Diff 61123

View Options

gfx/wr/webrender/src/clip.rs

View Options

gfx/wr/webrender/src/clip_scroll_tree.rs

View Options

gfx/wr/webrender/src/gpu_types.rs

View Options

gfx/wr/webrender/src/picture.rs

View Options

gfx/wr/webrender/src/prim_store/mod.rs

View Options

gfx/wr/webrender/src/spatial_node.rs

View Options

gfx/wr/webrender/src/util.rs

View Options

gfx/wr/wrench/reftests/transforms/content-offset.yaml

View Options

gfx/wr/wrench/reftests/transforms/flatten-preserve-3d-root-ref.yaml

View Options

gfx/wr/wrench/reftests/transforms/flatten-preserve-3d-root.yaml

View Options

gfx/wr/wrench/reftests/transforms/reftest.list

WR: rework the relative transform query on a clip-scroll treeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 61123

gfx/wr/webrender/src/clip.rs

gfx/wr/webrender/src/clip_scroll_tree.rs

gfx/wr/webrender/src/gpu_types.rs

gfx/wr/webrender/src/picture.rs

gfx/wr/webrender/src/prim_store/mod.rs

gfx/wr/webrender/src/spatial_node.rs

gfx/wr/webrender/src/util.rs

gfx/wr/wrench/reftests/transforms/content-offset.yaml

gfx/wr/wrench/reftests/transforms/flatten-preserve-3d-root-ref.yaml

gfx/wr/wrench/reftests/transforms/flatten-preserve-3d-root.yaml

gfx/wr/wrench/reftests/transforms/reftest.list

WR: rework the relative transform query on a clip-scroll tree
ClosedPublic
Actions

Revision Contents
Changeset List