Page MenuHomePhabricator
Differential D190537

Bug 1858062 - Remove reference to distutils in mozboot r=saschanaz
ClosedPublic
Actions

Authored by sergesanspaille on Oct 10 2023, 7:33 AM.
Tags
Referenced Files
Unknown Object (File)
Wed, Oct 15, 4:08 AM
Unknown Object (File)
Tue, Oct 14, 4:01 PM
Unknown Object (File)
Mon, Oct 13, 4:37 PM
Unknown Object (File)
Mar 23 2025, 7:39 AM
Unknown Object (File)
Mar 18 2025, 10:31 AM
Unknown Object (File)
Jan 12 2025, 7:10 PM
Unknown Object (File)
Aug 14 2024, 12:16 PM
Unknown Object (File)
Nov 30 2023, 8:41 AM
View All 9 Files
Subscribers
glandium

Details

Reviewers
saschanaz
glandium
Commits
rMOZILLACENTRAL201fc291a2c0: Bug 1858062 - Remove reference to distutils in mozboot r=saschanaz
Bugzilla Bug ID
1858062
Summary

distutils is no longer available in Python 3.12, which means we cannot
require it on bootstrap, otherwise we cannot bootstrap from Py 3.12.

We already require setuptools as part of mach's requirements, so it's
fine to depend on setuptools elsewhere.

Diff Detail

Event Timeline

sergesanspaille created this revision.Oct 10 2023, 7:33 AM
Herald added a project: secure-revision. · View Herald TranscriptOct 10 2023, 7:33 AM
Harbormaster completed remote builds in B585651: Diff 773522.Oct 10 2023, 7:33 AM
phab-bot published this revision for review.Oct 10 2023, 7:33 AM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
saschanaz accepted this revision.Oct 10 2023, 12:19 PM
saschanaz added a project: testing-exception-unchanged (Doesn't change behavior for users).

Looks good 👍

This revision is now accepted and ready to land.Oct 10 2023, 12:19 PM
saschanaz added inline comments.Oct 10 2023, 12:21 PM
python/mozboot/setup.py
8

In what situation would setuptools fail and require fallback, btw?

sergesanspaille added a subscriber: glandium.Oct 10 2023, 4:35 PM

I think we need to wait until we've removed all references to distutils from the codebase, cc @glandium for confirmation.

sergesanspaille added a reviewer: glandium.Oct 31 2023, 10:49 AM
Closed by commit rMOZILLACENTRAL201fc291a2c0: Bug 1858062 - Remove reference to distutils in mozboot r=saschanaz (authored by sergesanspaille). · Explain WhyNov 7 2023, 7:56 AM
This revision was automatically updated to reflect the committed changes.
sergesanspaille added a commit: rMOZILLACENTRAL201fc291a2c0: Bug 1858062 - Remove reference to distutils in mozboot r=saschanaz.
sergesanspaille mentioned this in rMOZILLACENTRALdbcd68806f5e: Bug 1858062 - Remove reference to distutils in mozboot a=pascalc.Feb 5 2024, 3:29 PM

Revision Contents
Changeset List

PathSize
python/
mozboot/
mozboot/
7 lines
16 lines
7 lines
5 lines

Diff 784148

View Options

python/mozboot/mozboot/base.py

Loading...
View Options

python/mozboot/mozboot/bootstrap.py

Loading...
View Options

python/mozboot/mozboot/debian.py

Loading...
View Options

python/mozboot/setup.py

Loading...
Privacy · Cookies · Legal