Following the official migration guide from
https://docs.python.org/3/whatsnew/3.12.html#imp
Details
Details
- Reviewers
saschanaz jgraham - Commits
- rMOZILLACENTRAL7257c0d54a96: Bug 1857516 [wpt PR 42578] - [Gecko Bug 1857516] Get rid of deprecated imp…
rMOZILLACENTRALc5f6eacd074b: Bug 1857516 - Get rid of deprecated imp python module in favor of importlib…
rMOZILLACENTRAL7f8e4fcfcbfa: Bug 1857516 - Get rid of deprecated imp python module in favor of importlib… - Bugzilla Bug ID
- 1857516
Diff Detail
Diff Detail
- Repository
- rMOZILLACENTRAL mozilla-central
Event Timeline
| dom/bindings/mozwebidlcodegen/test/test_mozwebidlcodegen.py | ||
|---|---|---|
| 23 | Maybe we should get a common helper function for this? | |
| dom/bindings/mozwebidlcodegen/test/test_mozwebidlcodegen.py | ||
|---|---|---|
| 29 | Maybe we should remove this comment or uncomment it if needed. | |
| tools/tryselect/test/test_mozharness_integration.py | ||
|---|---|---|
| 97 | This one should ideally also have a helper function. | |
Comment Actions
Code analysis found 3 defects in diff 774464:
- 1 defect found by py-black (Mozlint)
- 2 defects found by py-ruff (Mozlint)
IMPORTANT: Found 3 defects (error level) that must be fixed before landing.
You can run this analysis locally with:
- ./mach lint --warnings --outgoing
If you see a problem in this automated review, please report it here.
You can view these defects in the Diff Detail section of Phabricator diff 774464.
| testing/mozbase/mozfile/mozfile/mozfile.py | ||
|---|---|---|
| 646 | Do we want this comment here? I wonder it should be uncommented, as caching things should generally make things faster, and at least one test expects that: https://treeherder.mozilla.org/jobs?repo=try&revision=2af889f367f664227dbaabd0d721d76237fee71b&selectedTaskRun=STFFGhgWTYaDuM5RuHgsHQ.0 | |
| testing/web-platform/tests/service-workers/service-worker/resources/scope1/redirect.py | ||
| 3 | testing/web-platform/tests/ is external and shared with other browsers, and they probably won't get access to mozfile. We should probably have a separate helper function for WPT. | |
Comment Actions
Code analysis found 1 defect in diff 775052:
- 1 defect found by py-black (Mozlint)
2 defects closed compared to the previous diff 775046.
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.
You can run this analysis locally with:
- ./mach lint --warnings --outgoing
If you see a problem in this automated review, please report it here.
You can view these defects in the Diff Detail section of Phabricator diff 775052.
Comment Actions
1 defect closed compared to the previous diff 775052.
If you see a problem in this automated review, please report it here.