Page MenuHomePhabricator
Differential D185140

Bug 1846701 [Linux] Rename MOZ_WAYLAND_USE_HWDECODE to MOZ_USE_HWDECODE as we build HW decode on X11 too r?alwu
ClosedPublic
Actions

Authored by stransky on Aug 2 2023, 7:57 AM.
Tags
Referenced Files
Unknown Object (File)
Thu, Oct 16, 2:02 PM
Unknown Object (File)
May 10 2025, 12:05 PM
Unknown Object (File)
Mar 2 2025, 4:42 PM
Unknown Object (File)
Feb 12 2025, 5:48 PM
Unknown Object (File)
Jan 18 2025, 2:30 AM
Unknown Object (File)
Jan 8 2025, 12:37 AM
Subscribers
reviewbot

Details

Reviewers
alwu
Commits
rMOZILLACENTRAL4fb5d7fb0576: Bug 1846701 [Linux] Rename MOZ_WAYLAND_USE_HWDECODE to MOZ_USE_HWDECODE as we…
Bugzilla Bug ID
1846701

Diff Detail

Event Timeline

stransky created this revision.Aug 2 2023, 7:57 AM
Herald added a project: secure-revision. · View Herald TranscriptAug 2 2023, 7:57 AM
Harbormaster completed remote builds in B565430: Diff 749574.Aug 2 2023, 7:57 AM
phab-bot published this revision for review.Aug 2 2023, 7:58 AM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
reviewbot added a subscriber: reviewbot.Aug 2 2023, 8:38 AM

Code analysis found 40 defects in diff 749574:

  • 40 build errors found by clang-tidy
IMPORTANT: Found 40 defects (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 749574.

alwu accepted this revision.Aug 3 2023, 5:13 PM
alwu added a project: testing-exception-unchanged (Doesn't change behavior for users).
This revision is now accepted and ready to land.Aug 3 2023, 5:13 PM
Closed by commit rMOZILLACENTRAL4fb5d7fb0576: Bug 1846701 [Linux] Rename MOZ_WAYLAND_USE_HWDECODE to MOZ_USE_HWDECODE as we… (authored by stransky). · Explain WhyAug 4 2023, 7:42 AM
This revision was automatically updated to reflect the committed changes.
stransky added a commit: rMOZILLACENTRAL4fb5d7fb0576: Bug 1846701 [Linux] Rename MOZ_WAYLAND_USE_HWDECODE to MOZ_USE_HWDECODE as we….

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
dom/
media/
platforms/
ffmpeg/
2 lines--
6 lines100%
Loading...
32 lines48%
Loading...
ffmpeg58/
2 lines--
ffmpeg59/
2 lines--
ffmpeg60/
2 lines--
ffvpx/
2 lines--

Diff 750646

View Options

dom/media/platforms/ffmpeg/FFmpegLibs.h

Loading...
View Options

dom/media/platforms/ffmpeg/FFmpegVideoDecoder.h

Loading...
View Options

dom/media/platforms/ffmpeg/FFmpegVideoDecoder.cpp

Loading...
View Options

dom/media/platforms/ffmpeg/ffmpeg58/moz.build

Loading...
View Options

dom/media/platforms/ffmpeg/ffmpeg59/moz.build

Loading...
View Options

dom/media/platforms/ffmpeg/ffmpeg60/moz.build

Loading...
View Options

dom/media/platforms/ffmpeg/ffvpx/moz.build

Loading...
Privacy · Cookies · Legal