Page MenuHomePhabricator
Differential D184472

Bug 1837627 Implement GetColorRange() to convert AVColorRange to gfx::ColorRange r?alwu
ClosedPublic
Actions

Authored by stransky on Jul 25 2023, 12:21 PM.
Tags
Referenced Files
Unknown Object (File)
Thu, Oct 16, 1:07 AM
Unknown Object (File)
Sun, Sep 21, 10:06 PM
Unknown Object (File)
Sep 14 2025, 9:29 PM
Unknown Object (File)
May 24 2025, 10:52 PM
Unknown Object (File)
Jan 22 2025, 10:45 AM
Unknown Object (File)
Dec 29 2024, 4:20 AM
Subscribers
reviewbot

Details

Reviewers
alwu
Commits
rMOZILLACENTRALb42bac6cd95a: Bug 1837627 Implement GetColorRange() to convert AVColorRange to gfx…
Bugzilla Bug ID
1837627
Summary

Depends on D184469

Diff Detail

Event Timeline

stransky created this revision.Jul 25 2023, 12:21 PM
Herald added a project: secure-revision. · View Herald TranscriptJul 25 2023, 12:22 PM
Harbormaster completed remote builds in B562661: Diff 746425.Jul 25 2023, 12:22 PM
phab-bot published this revision for review.Jul 25 2023, 12:22 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
reviewbot added a subscriber: reviewbot.Jul 25 2023, 12:42 PM

Code analysis found 6 defects in diff 746425:

  • 6 build errors found by clang-tidy
IMPORTANT: Found 6 defects (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 746425.

alwu accepted this revision.Jul 26 2023, 10:31 PM
alwu added a project: testing-exception-unchanged (Doesn't change behavior for users).
This revision is now accepted and ready to land.Jul 26 2023, 10:31 PM
Closed by commit rMOZILLACENTRALb42bac6cd95a: Bug 1837627 Implement GetColorRange() to convert AVColorRange to gfx… (authored by stransky). · Explain WhyJul 27 2023, 8:47 AM
This revision was automatically updated to reflect the committed changes.
stransky added a commit: rMOZILLACENTRALb42bac6cd95a: Bug 1837627 Implement GetColorRange() to convert AVColorRange to gfx….
Harbormaster completed remote builds in B564023: Diff 747367.Aug 1 2023, 8:46 AM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
dom/
media/
platforms/
ffmpeg/
12 lines48%
Loading...

Diff 747367

View Options

dom/media/platforms/ffmpeg/FFmpegVideoDecoder.cpp

Loading...
Privacy · Cookies · Legal