Bug 1837627 Don't use YUVColorSpace::Identity for YUV pixel formats r?alwu
ClosedPublic
Actions

Authored by stransky on Jul 25 2023, 12:10 PM.

Details

Reviewers

alwu

Commits

rMOZILLACENTRAL0963f5b18821: Bug 1837627 Don't use YUVColorSpace::Identity for YUV pixel formats r=alwu

Bugzilla Bug ID

1837627

Summary

Check color space of video frames and use YUVColorSpace::Identity for RGB frames only. This patch also unifies color space setup for shm and non-shm video decoding paths.

Implement TransferAVColorSpaceToColorSpace() to convert color space from AVColorSpace to gfx::YUVColorSpace. It also check color format and doesn't allow to mix YUV color space and RGB formats.
Use TransferAVColorSpaceToColorSpace() in both shm and non-shm decoding paths.

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Build Status

Buildable 564022
Build 661625: arc lint + arc unit

Event Timeline

stransky created this revision.Jul 25 2023, 12:10 PM

Herald added a project: secure-revision. · View Herald TranscriptJul 25 2023, 12:10 PM

Harbormaster completed remote builds in B562653: Diff 746417.Jul 25 2023, 12:10 PM

phab-bot published this revision for review.Jul 25 2023, 12:10 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

stransky added a child revision: D184472: Bug 1837627 Implement GetColorRange() to convert AVColorRange to gfx::ColorRange r?alwu.Jul 25 2023, 12:21 PM

Code analysis found 5 defects in diff 746417:

5 build errors found by clang-tidy

IMPORTANT: Found 5 defects (error level) that must be fixed before landing.

You can run this analysis locally with:

./mach static-analysis check --outgoing (C/C++)

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 746417.

alwu accepted this revision.Jul 26 2023, 10:31 PM

alwu added a project: testing-exception-unchanged (Doesn't change behavior for users).

alwu added inline comments.

dom/media/platforms/ffmpeg/FFmpegVideoDecoder.cpp
616	Should we check other RGB formats as well? or `AV_PIX_FMT_GBRP` is the only RGB format we support?

This revision is now accepted and ready to land.Jul 26 2023, 10:31 PM

stransky marked an inline comment as done.Jul 27 2023, 8:39 AM

stransky added inline comments.

dom/media/platforms/ffmpeg/FFmpegVideoDecoder.cpp
616	We support AV_PIX_FMT_GBRP only: https://searchfox.org/mozilla-central/rev/00e6644d0db8acf9372702324151b8077a3d2bb7/dom/media/platforms/ffmpeg/FFmpegVideoDecoder.cpp#137