Page MenuHomePhabricator

Bug 1841571 - Treat rust libraries as objects in the build graph.
ClosedPublic

Authored by glandium on Jul 4 2023, 2:11 AM.
Referenced Files
Unknown Object (File)
Mon, Oct 13, 2:05 PM
Unknown Object (File)
Sat, Oct 11, 10:28 AM
Unknown Object (File)
Jul 8 2025, 11:23 PM
Unknown Object (File)
Jun 11 2025, 7:26 AM
Unknown Object (File)
Jul 4 2023, 3:53 AM
Subscribers

Details

Summary

The build graph has dependencies like:

some/dir/target: some/dir/target-objects

where some/dir/target-objects will build the objects in the directory,
and some/dir/target will link some binary (executable or shared library)
using those objects (and/or objects in other directories).

From that perspective, the rust (static) libraries are more similar to
objects, and we should treat them as such.

This will allow to add the right dependencies to use a in-tree-built tool
to link shared libraries without having building the rust libraries
depend on it just because they are treated as other binaries in the
build graph.

Diff Detail

Event Timeline

phab-bot published this revision for review.Jul 4 2023, 2:11 AM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
sergesanspaille added a subscriber: sergesanspaille.

+1 for archives being considered as objects.

This revision is now accepted and ready to land.Jul 4 2023, 6:48 AM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!