Bug 1841567 - Stop running check_binary on host binaries.
ClosedPublic
Actions

Authored by glandium on Jul 4 2023, 1:46 AM.

Details

Reviewers

sergesanspaille

Group Reviewers

Restricted Project

Commits

rMOZILLACENTRALaec57c7faed9: Bug 1841567 - Stop running check_binary on host binaries. r=firefox-build…

Bugzilla Bug ID

1841567

Summary

Back when this was added, we weren't using sysroots, and we did end up
with host binaries that couldn't run on the host because libstdc++ came
along the host compiler, and was newer than the system libstdc++. These
concerns are long gone (libstdc++ in the sysroots is older than any
supported linux host build system), so we don't need to run those checks
anymore.

Diff Detail

Repository: rMOZILLACENTRAL mozilla-central

Event Timeline

glandium created this revision.Jul 4 2023, 1:46 AM

Herald added a project: secure-revision. · View Herald TranscriptJul 4 2023, 1:46 AM

Harbormaster completed remote builds in B555801: Diff 738206.Jul 4 2023, 1:46 AM

phab-bot published this revision for review.Jul 4 2023, 1:46 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

sergesanspaille added a subscriber: sergesanspaille.Jul 4 2023, 8:58 AM

sergesanspaille added inline comments.

python/mozbuild/mozbuild/action/check_binary.py
167	Should we rewrite this as `if not (get_type(binary) == ELF and islibxul(binary)):` now ?
269	Can you explain to me why we're skipping instead of checking in that case?

glandium added inline comments.Jul 4 2023, 9:11 AM

python/mozbuild/mozbuild/action/check_binary.py
167	I have no strong opinion either way. One doesn't strike me as particularly better than the other.
269	Because it's a host library, but the build system doesn't know it is. And since we skip host libraries, we do the same.

Thanks for the clarification!

This revision is now accepted and ready to land.Jul 5 2023, 7:32 AM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!