Page MenuHomePhabricator
Differential D181738

Bug 1839023 - Fix missing arm-specifc header r=nbp
ClosedPublic
Actions

Authored by sergesanspaille on Jun 22 2023, 8:46 AM.
Tags
Referenced Files
Unknown Object (File)
Thu, Oct 16, 8:17 AM
Unknown Object (File)
Apr 23 2025, 1:00 AM
Unknown Object (File)
Mar 31 2025, 8:32 PM
Unknown Object (File)
Mar 19 2025, 1:11 PM
Unknown Object (File)
Jun 22 2023, 11:12 AM
Unknown Object (File)
Jun 22 2023, 10:19 AM
Subscribers
None

Details

Reviewers
nbp
Commits
rMOZILLACENTRAL34ef9f4d1d2c: Bug 1839023 - Fix missing arm-specifc header r=nbp
Bugzilla Bug ID
1839023

Diff Detail

Event Timeline

sergesanspaille created this revision.Jun 22 2023, 8:46 AM
Herald added a project: secure-revision. · View Herald TranscriptJun 22 2023, 8:46 AM
Harbormaster completed remote builds in B551816: Diff 733728.Jun 22 2023, 8:46 AM
phab-bot published this revision for review.Jun 22 2023, 8:48 AM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
nbp accepted this revision.Jun 22 2023, 10:36 AM
nbp added a project: testing-exception-unchanged (Doesn't change behavior for users).

I will accept for now, as I do not think many of us are concerned about using simulator builds on ARM platforms.
Also, there is a concern where the JIT is required to be initialized for HasAlignmentFault to be working properly, but I could not find a case where this might happen yet.

This revision is now accepted and ready to land.Jun 22 2023, 10:36 AM
Closed by commit rMOZILLACENTRAL34ef9f4d1d2c: Bug 1839023 - Fix missing arm-specifc header r=nbp (authored by sergesanspaille). · Explain WhyJun 22 2023, 4:18 PM
This revision was automatically updated to reflect the committed changes.
sergesanspaille added a commit: rMOZILLACENTRAL34ef9f4d1d2c: Bug 1839023 - Fix missing arm-specifc header r=nbp.
sergesanspaille mentioned this in rMOZILLACENTRAL340a8640da9f: Bug 1839023 - Fix missing arm-specifc header a=RyanVM.Jul 10 2023, 7:28 PM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
js/
src/
jit/
shared/
12 lines92%
Loading...

Diff 734038

View Options

js/src/jit/shared/AtomicOperations-shared-jit.cpp

Loading...
Privacy · Cookies · Legal