Bug 1838584 - Implement stripped down destructor for ProfilerParent, if MOZ_GECKO_PROFILER is undefined. r=mstange
ClosedPublic
Actions

Authored by msirringhaus on Jun 15 2023, 8:06 AM.

Details

Reviewers

Commits

rMOZILLACENTRALd80d61687ffc: Bug 1838584 - Implement stripped down destructor for ProfilerParent, if…
rMOZILLACENTRALcaf02cdd3199: Bug 1838584 - Implement stripped down destructor for ProfilerParent, if…

Bugzilla Bug ID

1838584

Summary

On platforms such as ppc64, MOZ_GECKO_PROFILER is not defined, leading to a busted build.
The destructor-implementation was hidden behind an MOZ_GECKO_PROFILER-ifdef.

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Build Status

Buildable 550912
Build 648237: arc lint + arc unit

Event Timeline

msirringhaus created this revision.Jun 15 2023, 8:06 AM

Herald added a project: secure-revision. · View Herald TranscriptJun 15 2023, 8:06 AM

Harbormaster completed remote builds in B548832: Diff 730145.Jun 15 2023, 8:06 AM

phab-bot published this revision for review.Jun 15 2023, 8:06 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

mstange accepted this revision.Jun 17 2023, 12:27 AM

mstange added a project: testing-exception-unchanged (Doesn't change behavior for users).

This revision is now accepted and ready to land.Jun 17 2023, 12:27 AM

Closed by commit rMOZILLACENTRALcaf02cdd3199: Bug 1838584 - Implement stripped down destructor for ProfilerParent, if… (authored by msirringhaus). · Explain WhyJun 20 2023, 9:21 AM

This revision was automatically updated to reflect the committed changes.

msirringhaus added a commit: rMOZILLACENTRALcaf02cdd3199: Bug 1838584 - Implement stripped down destructor for ProfilerParent, if….

msirringhaus added a commit: rMOZILLACENTRALd80d61687ffc: Bug 1838584 - Implement stripped down destructor for ProfilerParent, if….Jun 20 2023, 5:03 PM

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

tools/

profiler/

gecko/

ProfilerParent.cpp

4 lines

94%

Diff 732144

View Options

tools/profiler/gecko/ProfilerParent.cpp

Bug 1838584 - Implement stripped down destructor for ProfilerParent, if MOZ_GECKO_PROFILER is undefined. r=mstangeClosedPublicActions