Page MenuHomePhabricator
Differential D175391

Bug 1827950 - Don't attempt to use font extents if we didn't get a valid 'head' table, or if it's not an sfnt resource. r=lsalzman
ClosedPublic
Actions

Authored by jfkthame on Apr 13 2023, 6:25 PM.
Tags
Referenced Files
Unknown Object (File)
Wed, Oct 8, 7:02 PM
Unknown Object (File)
Sep 15 2025, 4:44 PM
Unknown Object (File)
Sep 14 2025, 9:23 PM
Unknown Object (File)
Jun 18 2025, 12:56 PM
Unknown Object (File)
May 29 2025, 9:54 PM
Unknown Object (File)
Jan 10 2025, 1:17 AM
Unknown Object (File)
May 7 2023, 7:09 PM
Unknown Object (File)
Apr 30 2023, 11:37 AM
View All 15 Files
Subscribers
reviewbot

Details

Reviewers
lsalzman
Commits
rMOZILLACENTRAL80b83057f86b: Bug 1827950 - Don't attempt to use font extents if we didn't get a valid 'head'…
rMOZILLACENTRALe05a8b4d3065: Bug 1827950 - Don't attempt to use font extents if we didn't get a valid 'head'…
rMOZILLACENTRAL18b8f731cb69: Bug 1827950 - Don't attempt to use font extents if we didn't get a valid 'head'…
Bugzilla Bug ID
1827950
Test Plan

No automated test - dependent on bitmap fonts installed on the system.

Diff Detail

Event Timeline

jfkthame created this revision.Apr 13 2023, 6:25 PM
Herald added a project: secure-revision. · View Herald TranscriptApr 13 2023, 6:25 PM
Harbormaster completed remote builds in B526897: Diff 704421.Apr 13 2023, 6:25 PM
phab-bot published this revision for review.Apr 13 2023, 6:26 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
reviewbot added a subscriber: reviewbot.Apr 13 2023, 7:16 PM

Code analysis found 150 defects in the diff 704421:

  • 150 build errors found by clang-tidy
IMPORTANT: Found 150 issues (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 704421.

lsalzman accepted this revision.Apr 13 2023, 11:16 PM
This revision is now accepted and ready to land.Apr 13 2023, 11:16 PM
Herald added a project: needs-testing-tag. · View Herald TranscriptApr 13 2023, 11:16 PM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

jfkthame edited the test plan for this revision. (Show Details)Apr 14 2023, 11:53 AM
jfkthame edited projects, added testing-exception-other (Please leave a comment explaining why) ; removed needs-testing-tag.
Closed by commit rMOZILLACENTRAL18b8f731cb69: Bug 1827950 - Don't attempt to use font extents if we didn't get a valid 'head'… (authored by jfkthame). · Explain WhyApr 14 2023, 11:59 AM
This revision was automatically updated to reflect the committed changes.
jfkthame added a commit: rMOZILLACENTRAL18b8f731cb69: Bug 1827950 - Don't attempt to use font extents if we didn't get a valid 'head'….
Harbormaster completed remote builds in B527483: Diff 704732.Apr 16 2023, 8:07 AM
jfkthame added a commit: rMOZILLACENTRALe05a8b4d3065: Bug 1827950 - Don't attempt to use font extents if we didn't get a valid 'head'….Apr 16 2023, 1:31 PM
jfkthame added a commit: rMOZILLACENTRAL80b83057f86b: Bug 1827950 - Don't attempt to use font extents if we didn't get a valid 'head'….Apr 22 2023, 2:06 PM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
gfx/
thebes/
10 lines86%
Loading...
11 lines53%
Loading...

Diff 704732

View Options

gfx/thebes/gfxFont.cpp

Loading...
View Options

gfx/thebes/gfxFontEntry.cpp

Loading...
Privacy · Cookies · Legal