Page MenuHomePhabricator
Differential D175138

Bug 1827429 [Wayland] Call NotifyOcclusionState(OcclusionState::VISIBLE) from nsWindow::OnExposeEvent() as we know the window is visible r?emilio
ClosedPublic
Actions

Authored by stransky on Apr 11 2023, 2:39 PM.
Tags
Referenced Files
Unknown Object (File)
Mon, Oct 13, 9:09 AM
Unknown Object (File)
Sat, Oct 11, 3:19 PM
Unknown Object (File)
Jul 22 2025, 3:15 AM
Unknown Object (File)
May 27 2025, 6:42 PM
Unknown Object (File)
Apr 30 2025, 2:49 AM
Unknown Object (File)
Apr 19 2025, 2:48 AM
Unknown Object (File)
Apr 5 2025, 9:33 AM
Unknown Object (File)
Mar 3 2025, 8:15 PM
View All 28 Files
Subscribers
karlt

Details

Reviewers
emilio
Commits
rMOZILLACENTRAL48bcf011c5d5: Bug 1827429 [Wayland] Call NotifyOcclusionState(OcclusionState::VISIBLE) from…
rMOZILLACENTRALa559fcdcfccf: Bug 1827429 [Wayland] Call NotifyOcclusionState(OcclusionState::VISIBLE) from…
rMOZILLACENTRALf2b8b117022c: Bug 1827429 [Wayland] Call NotifyOcclusionState(OcclusionState::VISIBLE) from…
Bugzilla Bug ID
1827429

Diff Detail

Event Timeline

stransky created this revision.Apr 11 2023, 2:39 PM
Herald added a project: secure-revision. · View Herald TranscriptApr 11 2023, 2:39 PM
Harbormaster completed remote builds in B525872: Diff 703198.Apr 11 2023, 2:39 PM
phab-bot published this revision for review.Apr 11 2023, 2:39 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Herald added a subscriber: karlt. · View Herald TranscriptApr 11 2023, 2:39 PM
emilio accepted this revision.Apr 11 2023, 5:17 PM
emilio added a project: testing-approved.

Looks good with that tweak unless it's not possible for some reason.

widget/gtk/nsWindow.cpp
3745

Should we do this before resized? It's plausible that someone could call window.minimize() on a resize event for example.

This revision is now accepted and ready to land.Apr 11 2023, 5:17 PM
stransky updated this revision to Diff 703635.Apr 12 2023, 9:11 AM
stransky marked an inline comment as done.
Harbormaster completed remote builds in B526231: Diff 703635.Apr 12 2023, 9:11 AM
Closed by commit rMOZILLACENTRALf2b8b117022c: Bug 1827429 [Wayland] Call NotifyOcclusionState(OcclusionState::VISIBLE) from… (authored by stransky). · Explain WhyApr 12 2023, 9:23 AM
This revision was automatically updated to reflect the committed changes.
stransky added a commit: rMOZILLACENTRALf2b8b117022c: Bug 1827429 [Wayland] Call NotifyOcclusionState(OcclusionState::VISIBLE) from….
stransky added a commit: rMOZILLACENTRALa559fcdcfccf: Bug 1827429 [Wayland] Call NotifyOcclusionState(OcclusionState::VISIBLE) from….Apr 13 2023, 9:05 AM
Harbormaster completed remote builds in B526679: Diff 703637.Apr 13 2023, 9:05 AM
stransky added a commit: rMOZILLACENTRAL48bcf011c5d5: Bug 1827429 [Wayland] Call NotifyOcclusionState(OcclusionState::VISIBLE) from….Apr 22 2023, 2:06 PM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
widget/
gtk/
9 lines47%
Loading...

Diff 703637

View Options

widget/gtk/nsWindow.cpp

Loading...
Privacy · Cookies · Legal