Page MenuHomePhabricator

Bug 1803016 [Wayland] Don't commit wl_buffer if buffer scale doesn't match its size r?rmader,emilio
ClosedPublic

Authored by stransky on Mar 28 2023, 9:24 AM.
Referenced Files
Unknown Object (File)
Wed, Oct 15, 2:22 PM
Unknown Object (File)
Wed, Oct 15, 1:26 PM
Unknown Object (File)
Mon, Oct 13, 6:25 PM
Unknown Object (File)
Apr 26 2025, 6:42 PM
Unknown Object (File)
Apr 11 2025, 2:27 AM
Unknown Object (File)
Apr 17 2023, 9:56 PM

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.

Code analysis found 6 defects in the diff 698195:

  • 2 defects found by code coverage analysis
  • 4 build errors found by clang-tidy
WARNING: Found 2 issues (warning level) that can be dismissed.
IMPORTANT: Found 4 issues (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code?

  • You can file a bug blocking Bug 1415824 for untested files that should be tested.
  • You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 698195.

stransky retitled this revision from Bug 1803016 [Wayland] Don't commit wl_buffer if buffer scale doesn't match its size r?rmader to Bug 1803016 [Wayland] Don't commit wl_buffer if buffer scale doesn't match its size r?rmader,emilio.

Code analysis found 2 defects in the diff 699169:

  • 2 defects found by code coverage analysis

6 issues closed compared to the previous diff 698195.

WARNING: Found 2 issues (warning level) that can be dismissed.

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code?

  • You can file a bug blocking Bug 1415824 for untested files that should be tested.
  • You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 699169.

testing: We don't test on Wayland on automation yet.

This revision is now accepted and ready to land.Mar 30 2023, 11:46 AM