Bug 1822747 - Add a 'pushValue' function in MacroAssembler.r=jandem
ClosedPublic
Actions

Authored by yahan on Mar 16 2023, 7:20 AM.

Details

Reviewers

jandem

Commits

rMOZILLACENTRALf2cd6873bc2a: Bug 1822747 - Add a 'pushValue' function in MacroAssembler.r=jandem

Bugzilla Bug ID

1822747

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Build Status

Buildable 518868
Build 615468: arc lint + arc unit

Event Timeline

yahan created this revision.Mar 16 2023, 7:20 AM

Herald added a project: secure-revision. · View Herald TranscriptMar 16 2023, 7:20 AM

Harbormaster completed remote builds in B517774: Diff 693633.Mar 16 2023, 7:20 AM

phab-bot published this revision for review.Mar 16 2023, 7:20 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

yahan edited the summary of this revision. (Show Details)Mar 16 2023, 7:25 AM

Code analysis found 3 defects in the diff 693633:

1 defect found by clang-format
1 defect found by code coverage analysis
1 defect found by file-whitespace (Mozlint)

WARNING: Found 2 issues (warning level) that can be dismissed.

IMPORTANT: Found 1 issue (error level) that must be fixed before landing.

You can run this analysis locally with:

./mach clang-format -p js/src/jit/riscv64/MacroAssembler-riscv64.h
./mach lint --warnings --outgoing

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 693633.

yahan updated this revision to Diff 693710.Mar 16 2023, 11:03 AM

yahan edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B517838: Diff 693710.Mar 16 2023, 11:03 AM

Code analysis found 1 defect in the diff 693710:

1 defect found by code coverage analysis

1 issue unresolved and 2 issues closed compared to the previous diff 693633.

WARNING: Found 1 issue (warning level) that can be dismissed.

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 693710.

jandem accepted this revision.Mar 20 2023, 9:40 AM

jandem added a project: testing-exception-unchanged (Doesn't change behavior for users).

This revision is now accepted and ready to land.Mar 20 2023, 9:40 AM

jandem mentioned this in D172825: Bug 1822748 - Fix typo on jit/moz.build. r=jandem.Mar 20 2023, 9:41 AM

Closed by commit rMOZILLACENTRALf2cd6873bc2a: Bug 1822747 - Add a 'pushValue' function in MacroAssembler.r=jandem (authored by yahan). · Explain WhyMar 20 2023, 9:48 AM

This revision was automatically updated to reflect the committed changes.

yahan added a commit: rMOZILLACENTRALf2cd6873bc2a: Bug 1822747 - Add a 'pushValue' function in MacroAssembler.r=jandem.