Page MenuHomePhabricator
Differential D169150

Bug 1800678 - enable nimbus experimentation for CBH doorhanger. r?mardak,barret
ClosedPublic
Actions

Authored by dwalker on Feb 7 2023, 10:42 PM.

Details

Reviewers
Mardak
beth
flod
Group Reviewers
Restricted Project
Commits
rMOZILLACENTRAL920c41311112: Bug 1800678 - enable nimbus experimentation for CBH doorhanger. r=barret,fluent…
Bugzilla Bug ID
1800678

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Lint Not Applicable
Unit
Tests Not Applicable
Build Status
Buildable 509446
Build 605850: arc lint + arc unit

Event Timeline

dwalker created this revision.Feb 7 2023, 10:42 PM
Herald added a project: secure-revision. · View Herald TranscriptFeb 7 2023, 10:42 PM
Harbormaster completed remote builds in B505051: Diff 678416.Feb 7 2023, 10:42 PM
phab-bot published this revision for review.Feb 7 2023, 10:43 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
dwalker updated this revision to Diff 678738.Feb 8 2023, 4:52 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 8 2023, 4:52 PM
Herald added subscribers: andreio, flod. · View Herald Transcript
Harbormaster completed remote builds in B505308: Diff 678738.Feb 8 2023, 4:52 PM
dwalker added a comment.Feb 8 2023, 4:53 PM

just adding a note that this patch now includes a last-minute copy revision

beth accepted this revision.Feb 8 2023, 5:01 PM
beth added a project: testing-exception-unchanged (Doesn't change behavior for users).
flod accepted this revision.Feb 8 2023, 5:04 PM
flod added inline comments.
browser/locales/en-US/browser/newtab/asrouter.ftl
213

Can I point out how confusing the IDs are at this point?

This revision is now accepted and ready to land.Feb 8 2023, 5:04 PM
dwalker added inline comments.Feb 8 2023, 5:20 PM
browser/locales/en-US/browser/newtab/asrouter.ftl
213

I know, I'm so sorry, naming things is hard. The A/B message variants will be removed when the experiment is over so it should be less confusing at that point at least

Closed by commit rMOZILLACENTRAL920c41311112: Bug 1800678 - enable nimbus experimentation for CBH doorhanger. r=barret,fluent… (authored by dwalker). · Explain WhyFeb 8 2023, 5:58 PM
This revision was automatically updated to reflect the committed changes.
dwalker added a commit: rMOZILLACENTRAL920c41311112: Bug 1800678 - enable nimbus experimentation for CBH doorhanger. r=barret,fluent….

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
browser/
app/
profile/
3 lines--
components/
newtab/
lib/
174 lines97%
Loading...
locales/
en-US/
browser/
newtab/
2 lines--
toolkit/
components/
nimbus/
30 lines--

Diff 678764

View Options

browser/app/profile/firefox.js

Loading...
View Options

browser/components/newtab/lib/OnboardingMessageProvider.jsm

Loading...
View Options

browser/locales/en-US/browser/newtab/asrouter.ftl

Loading...
View Options

toolkit/components/nimbus/FeatureManifest.yaml

Loading...
Privacy · Cookies · Legal