Paths

Table of Contentst

Differential D168816

Bug 1790022 - Add "Learn more" item to the urlbar result menu for history items. r=mak
ClosedPublic
Actions

Authored by dao on Feb 3 2023, 4:23 PM.

Tags

Referenced Files

	Unknown Object (File)
	Jan 20 2025, 2:14 AM

	Unknown Object (File)
	Jan 17 2025, 1:06 AM

	Unknown Object (File)
	Jan 14 2025, 8:12 PM

	Unknown Object (File)
	Nov 29 2024, 3:23 AM

	Unknown Object (File)
	Feb 7 2023, 8:54 PM

Subscribers

Details

Reviewers

flod
jteow

Group Reviewers

Restricted Project

Commits

rMOZILLACENTRAL3cb427515341: Bug 1790022 - Add "Learn more" item to the urlbar result menu for history items.

Bugzilla Bug ID

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Build Status

Buildable 505039
Build 601392: arc lint + arc unit

Event Timeline

dao created this revision.Feb 3 2023, 4:23 PM

Herald added a project: secure-revision. · View Herald TranscriptFeb 3 2023, 4:23 PM

Herald added a reviewer: Restricted Project. · View Herald Transcript

Harbormaster completed remote builds in B503312: Diff 677064.Feb 3 2023, 4:23 PM

Herald added a subscriber: flod. · View Herald TranscriptFeb 3 2023, 4:23 PM

phab-bot published this revision for review.Feb 3 2023, 4:23 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

flod accepted this revision.Feb 5 2023, 6:28 AM

This revision is now accepted and ready to land.Feb 5 2023, 6:28 AM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

dao added 1 blocking reviewer(s): mak.Feb 6 2023, 11:48 AM

This revision now requires review to proceed.Feb 6 2023, 11:48 AM

dao added a reviewer: jteow.Feb 6 2023, 5:11 PM

LGTM. Also ran tests locally and on TreeHerder just to be sure.

mak added inline comments.Feb 7 2023, 8:38 AM

browser/components/urlbar/UrlbarView.sys.mjs
2942	question: why do we use awesome-bar here? That's just an internal coding name, officially we should use address-bar or url-bar. What will this article contain?

Gonna go ahead and land this to unblock bug 1810113

browser/components/urlbar/UrlbarView.sys.mjs
2942	question: why do we use awesome-bar here? That's just an internal coding name, officially we should use address-bar or url-bar. It's just a redirect anyway, so this is still sort of internal use. What will this article contain? Idk, I think it's still to be determined. I've added you to the slack channel where you can follow the initial discussion between Henry and Fabi from SUMO. Feel free to weigh in there.

This revision is now accepted and ready to land.Feb 7 2023, 10:15 AM

Herald added a subscriber: mak. · View Herald TranscriptFeb 7 2023, 10:15 AM

dao marked an inline comment as done.Feb 7 2023, 10:16 AM

Closed by commit rMOZILLACENTRAL3cb427515341: Bug 1790022 - Add "Learn more" item to the urlbar result menu for history items. (authored by dao). · Explain WhyFeb 7 2023, 11:13 AM

This revision was automatically updated to reflect the committed changes.

dao added a commit: rMOZILLACENTRAL3cb427515341: Bug 1790022 - Add "Learn more" item to the urlbar result menu for history items..

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

browser/

components/

urlbar/

UrlbarView.sys.mjs

10 lines

96%

Loading...

tests/

browser/

browser_result_menu.js

27 lines

-

-

locales/

en-US/

browser/

3 lines

-

-

Diff 678101

browser/components/urlbar/UrlbarView.sys.mjs

Loading...

browser/components/urlbar/tests/browser/browser_result_menu.js

Loading...

browser/locales/en-US/browser/browser.ftl

Loading...