Page MenuHomePhabricator
Differential D168202

Bug 1813341 - Check topBrowsingContext is not null before using it. r?ochameau
ClosedPublic
Actions

Authored by def00111 on Jan 28 2023, 10:12 PM.
Tags
Referenced Files
Unknown Object (File)
Thu, May 1, 6:55 AM
Unknown Object (File)
Thu, Apr 17, 9:45 AM
Unknown Object (File)
Wed, Apr 16, 10:42 PM
Unknown Object (File)
Apr 9 2025, 10:16 PM
Unknown Object (File)
Mar 15 2025, 6:06 AM
Unknown Object (File)
Mar 1 2025, 6:57 AM
Unknown Object (File)
Feb 16 2025, 7:21 AM
Unknown Object (File)
Feb 1 2025, 7:25 AM
View All 38 Files
Subscribers
None

Details

Reviewers
ochameau
Commits
rMOZILLACENTRAL5caac5585da4: Bug 1813341 - Check topBrowsingContext is not null before using it. r=ochameau
Bugzilla Bug ID
1813341

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Lint Not Applicable
Unit
Tests Not Applicable
Build Status
Buildable 504185
Build 600525: arc lint + arc unit

Event Timeline

def00111 created this revision.Jan 28 2023, 10:12 PM
Herald added a project: secure-revision. · View Herald TranscriptJan 28 2023, 10:12 PM
Harbormaster completed remote builds in B501513: Diff 674624.Jan 28 2023, 10:12 PM
phab-bot published this revision for review.Jan 28 2023, 10:12 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
ochameau accepted this revision.Feb 1 2023, 7:43 PM
ochameau added a project: testing-exception-other (Please leave a comment explaining why) .

testing: this prevents an exception involving an addon, which doesn't really break anything.

devtools/server/actors/watcher/browsing-context-helpers.sys.mjs
382–391

Could you add a comment to mention that we may not have any BrowsingContext if this code runs against an unloaded tab?

This revision is now accepted and ready to land.Feb 1 2023, 7:43 PM
def00111 updated this revision to Diff 676239.Feb 1 2023, 9:25 PM
Harbormaster completed remote builds in B502707: Diff 676239.Feb 1 2023, 9:25 PM
def00111 added inline comments.Feb 1 2023, 9:27 PM
devtools/server/actors/watcher/browsing-context-helpers.sys.mjs
382–391

Is this comment ok?

ochameau added inline comments.Feb 3 2023, 10:27 AM
devtools/server/actors/watcher/browsing-context-helpers.sys.mjs
382–391

Yes, thanks for your contribution!

Closed by commit rMOZILLACENTRAL5caac5585da4: Bug 1813341 - Check topBrowsingContext is not null before using it. r=ochameau (authored by def00111). · Explain WhyFeb 3 2023, 10:34 AM
This revision was automatically updated to reflect the committed changes.
def00111 added a commit: rMOZILLACENTRAL5caac5585da4: Bug 1813341 - Check topBrowsingContext is not null before using it. r=ochameau.
def00111 marked an inline comment as done.Feb 3 2023, 11:33 AM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
devtools/
server/
actors/
watcher/
17 lines87%
Loading...

Diff 676929

View Options

devtools/server/actors/watcher/browsing-context-helpers.sys.mjs

Loading...
Privacy · Cookies · Legal