Bug 1516365 - Update the Rust target version for bindgen.
ClosedPublic
Actions

Authored by emilio on Dec 25 2018, 10:41 PM.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

Restricted Diffusion Commit
rMOZILLACENTRALaf22225148f7: Bug 1516365 - Update the Rust target version for bindgen. r=xidorn

Bugzilla Bug ID

1516365

Summary

This brings us alignas support and also associated constants for bitfield enums.

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Build Status

Buildable 29301
Build 39508: arc lint + arc unit

Event Timeline

emilio created this revision.Dec 25 2018, 10:41 PM

Herald added a project: Restricted Project. · View Herald TranscriptDec 25 2018, 10:41 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Dec 25 2018, 10:42 PM

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: Restricted Project.

Harbormaster completed remote builds in B29202: Diff 47213.Dec 25 2018, 10:42 PM

emilio requested review of this revision.Dec 25 2018, 10:42 PM

I wonder whether we can just bump the target version to the latest one (i.e. 1.27), although there doesn't seem to be new features we really need at the moment...

This revision is now accepted and ready to land.Dec 25 2018, 11:06 PM

Yeah, I suspect there's no problem with that, but I just didn't feel the need. I have a pretty big patch queue that I'd want to land for https://bugzilla.mozilla.org/show_bug.cgi?id=1516366, and it didn't seem worth looking for more trouble :)

Closed by commit rMOZILLACENTRALaf22225148f7: Bug 1516365 - Update the Rust target version for bindgen. r=xidorn (authored by emilio). · Explain WhyDec 25 2018, 11:10 PM

This revision was automatically updated to reflect the committed changes.