Page MenuHomePhabricator
Differential D15284

Bug 1516221 - changes to implement enum class for #define NS_STYLE_COLOR_ADJUST. r=emilio
ClosedPublic
Actions

Authored by qwerty29 on Dec 24 2018, 6:34 AM.

Details

Reviewers
emilio
Commits
Restricted Diffusion Commit
rMOZILLACENTRALf4556b4f6917: Bug 1516221 - changes to implement enum class for #define NS_STYLE_COLOR_ADJUST.
Bugzilla Bug ID
1516221

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Build Status
Buildable 29171
Build 39325: arc lint + arc unit

Event Timeline

qwerty29 created this revision.Dec 24 2018, 6:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 24 2018, 6:34 AM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Dec 24 2018, 6:34 AM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.
Harbormaster completed remote builds in B29110: Diff 47105.Dec 24 2018, 6:34 AM
qwerty29 requested review of this revision.Dec 24 2018, 6:34 AM
emilio requested changes to this revision.Dec 24 2018, 10:52 AM

Thanks for the patch! Below is the reason for the build failure :)

layout/style/ServoBindings.toml
143

You're missing a comma here.

This revision now requires changes to proceed.Dec 24 2018, 10:52 AM
qwerty29 updated this revision to Diff 47125.Dec 24 2018, 2:50 PM

Revision updated.

Harbormaster completed remote builds in B29130: Diff 47125.Dec 24 2018, 2:50 PM
qwerty29 added a child revision: D15299: Bug 1516221 - convert NS_STYLE_COLOR_ADJUST to an enum class in nsStyleConsts.h. r=emilio.Dec 24 2018, 2:50 PM
qwerty29 updated this revision to Diff 47127.Dec 24 2018, 3:15 PM
qwerty29 marked an inline comment as done.

Revision updated.

Harbormaster completed remote builds in B29132: Diff 47127.Dec 24 2018, 3:15 PM
emilio accepted this revision.Dec 24 2018, 3:28 PM

Looks great, thank you!

This revision is now accepted and ready to land.Dec 24 2018, 3:28 PM
Closed by commit rMOZILLACENTRALf4556b4f6917: Bug 1516221 - changes to implement enum class for #define NS_STYLE_COLOR_ADJUST. (authored by qwerty29). · Explain WhyDec 24 2018, 4:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
layout/
painting/
2 lines86%
Loading...
style/
1 line--
6 lines--
2 lines0%
Loading...
2 lines91%
Loading...
servo/
components/
style/
properties/
longhands/
1 line--

Diff 47141

View Options

layout/painting/nsCSSRendering.cpp

Loading...
View Options

layout/style/ServoBindings.toml

Loading...
View Options

layout/style/nsStyleConsts.h

Loading...
View Options

layout/style/nsStyleStruct.h

Loading...
View Options

layout/style/nsStyleStruct.cpp

Loading...
View Options

servo/components/style/properties/longhands/inherited_box.mako.rs

Loading...
Privacy · Cookies · Legal