Page MenuHomePhabricator
Differential D149386

Bug 1758948 [FFmpeg] Use AVFrame::pts instead of AVFrame::pkt_pts on ffmpeg 4.x r?alwu
ClosedPublic
Actions

Authored by stransky on Jun 15 2022, 12:57 PM.
Tags
Referenced Files
Unknown Object (File)
Thu, Oct 16, 3:22 PM
Unknown Object (File)
Wed, Oct 15, 2:11 AM
Unknown Object (File)
Mon, Oct 13, 11:08 PM
Unknown Object (File)
Sep 17 2025, 7:21 AM
Unknown Object (File)
Jan 22 2025, 3:48 PM
Unknown Object (File)
Sep 27 2024, 9:01 PM
Unknown Object (File)
Jul 1 2022, 10:13 AM
Subscribers
reviewbot

Details

Reviewers
alwu
Commits
rMOZILLACENTRAL89f793811320: Bug 1758948 [FFmpeg] Use AVFrame::pts instead of AVFrame::pkt_pts on ffmpeg 4.x…
Bugzilla Bug ID
1758948
Summary

AVFrame::pkt_pts has been deprecated and gives us wrong values for AV1 VA-API. Let's use AVFrame::pts instead on ffmpeg 4.x
as well as we use on ffmpeg 5.0 where AVFrame::pkt_pts is removed.

Diff Detail

Event Timeline

stransky created this revision.Jun 15 2022, 12:57 PM
Herald added a project: secure-revision. · View Herald TranscriptJun 15 2022, 12:57 PM
Harbormaster completed remote builds in B433619: Diff 590927.Jun 15 2022, 12:57 PM
phab-bot published this revision for review.Jun 15 2022, 12:57 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
reviewbot added a subscriber: reviewbot.Jun 15 2022, 1:22 PM

Code analysis found 121 defects in the diff 590927:

  • 121 build errors found by clang-tidy

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

alwu accepted this revision.Jun 16 2022, 1:18 AM
alwu added a project: testing-exception-unchanged (Doesn't change behavior for users).
This revision is now accepted and ready to land.Jun 16 2022, 1:18 AM
Closed by commit rMOZILLACENTRAL89f793811320: Bug 1758948 [FFmpeg] Use AVFrame::pts instead of AVFrame::pkt_pts on ffmpeg 4.x… (authored by stransky). · Explain WhyJun 16 2022, 6:27 AM
This revision was automatically updated to reflect the committed changes.
stransky added a commit: rMOZILLACENTRAL89f793811320: Bug 1758948 [FFmpeg] Use AVFrame::pts instead of AVFrame::pkt_pts on ffmpeg 4.x….
Harbormaster completed remote builds in B434102: Diff 591368.Jun 29 2022, 12:51 PM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
dom/
media/
platforms/
ffmpeg/
2 lines54%
Loading...

Diff 591368

View Options

dom/media/platforms/ffmpeg/FFmpegVideoDecoder.cpp

Loading...
Privacy · Cookies · Legal