Bug 1769631 - Remove 'U' from 'mode' parameters for various 'open' calls to ensure Python3.11 compatibility r?#build
ClosedPublic
Actions

Authored by ahochheiden on May 31 2022, 7:52 AM.

Details

Reviewers

glandium

Group Reviewers

Restricted Project

Commits

rMOZILLACENTRAL1345ee1bfd75: Bug 1769631 - Remove 'U' from 'mode' parameters for various 'open' calls to…
rMOZILLACENTRALf54162b2c1f2: Bug 1769631 - Remove 'U' from 'mode' parameters for various 'open' calls to…

Bugzilla Bug ID

1769631

Summary

The 'U' flag represents "universal newline". It has been deprecated
since Python3.3. Since then "universal newline" is the default when a
file is opened in text mode (not bytes). In Python3.11 using the 'U'
flag throws errors. There should be no harm in removing 'U' from 'open'
everywhere it is used, and doing allows the use of Python3.11.

For more reading see: https://docs.python.org/3.11/whatsnew/3.11.html#changes-in-the-python-api

Diff Detail

Repository: rMOZILLACENTRAL mozilla-central

Event Timeline

ahochheiden created this revision.May 31 2022, 7:52 AM

Herald added a project: secure-revision. · View Herald TranscriptMay 31 2022, 7:52 AM

Harbormaster completed remote builds in B428229: Diff 584564.May 31 2022, 7:52 AM

phab-bot published this revision for review.May 31 2022, 7:52 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f1116af11978d4e18e07da2f6ba03b1ff06b16af

glandium accepted this revision.Jun 1 2022, 8:53 AM

This revision is now accepted and ready to land.Jun 1 2022, 8:53 AM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!