Page MenuHomePhabricator
Differential D14672

Bug 1514449 - Cleanup some conversion code dealing with NonNegative. r=boris,#style
ClosedPublic
Actions

Authored by emilio on Dec 15 2018, 4:49 AM.

Details

Reviewers
boris
xidorn
Group Reviewers
Restricted Project
Commits
Restricted Diffusion Commit
rMOZILLACENTRALce1adc43434d: Bug 1514449 - Cleanup some conversion code dealing with NonNegative. r=boris…
Bugzilla Bug ID
1514449
Summary

I'm about to introduce another use of it and I don't want to repeat the same
copy-pasta again.

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Build Status
Buildable 27953
Build 37779: arc lint + arc unit

Event Timeline

emilio created this revision.Dec 15 2018, 4:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 15 2018, 4:49 AM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Dec 15 2018, 4:50 AM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.
Harbormaster completed remote builds in B27436: Diff 44744.Dec 15 2018, 4:50 AM
emilio requested review of this revision.Dec 15 2018, 4:50 AM
emilio added a child revision: D14673: Bug 1514449 - Use NonNegative more in the border code. r=boris,#style.Dec 15 2018, 4:50 AM
xidorn accepted this revision as: xidorn.Dec 15 2018, 4:59 AM
This revision is now accepted and ready to land.Dec 15 2018, 4:59 AM
boris accepted this revision.Dec 16 2018, 9:13 AM
Closed by commit rMOZILLACENTRALce1adc43434d: Bug 1514449 - Cleanup some conversion code dealing with NonNegative. r=boris… (authored by emilio). · Explain WhyDec 17 2018, 9:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
servo/
components/
style/
gecko/
48 lines96%
Loading...

Diff 45193

View Options

servo/components/style/gecko/values.rs

Loading...
Privacy · Cookies · Legal