Page MenuHomePhabricator
Differential D14548

Bug 1513920 - Make <use> shadow trees lookup keyframe rules in the containing tree.
ClosedPublic
Actions

Authored by emilio on Dec 14 2018, 1:33 PM.

Details

Reviewers
heycam
Commits
rMOZILLACENTRALb3837d6171d2: Bug 1513920 - Make <use> shadow trees lookup keyframe rules in the containing…
Restricted Diffusion Commit
Restricted Diffusion Commit
rMOZILLACENTRAL1b1eaa3248a7: Bug 1513920 - Make <use> shadow trees lookup keyframe rules in the containing…
Bugzilla Bug ID
1513920
Summary

The same thing we do for rule matching.

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Build Status
Buildable 27848
Build 37662: arc lint + arc unit

Event Timeline

emilio created this revision.Dec 14 2018, 1:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 14 2018, 1:33 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Dec 14 2018, 1:33 PM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.
Harbormaster completed remote builds in B27187: Diff 44395.Dec 14 2018, 1:33 PM
emilio requested review of this revision.Dec 14 2018, 1:33 PM
heycam accepted this revision as: heycam.Dec 17 2018, 4:47 AM
heycam added a subscriber: heycam.
heycam added inline comments.
servo/components/style/stylist.rs
1193–1195

Can you add a short comment here about why we're using the ignoring_svg_use version, maybe pointing to the big comment that's now on that function?

testing/web-platform/tests/svg/linking/reftests/use-keyframes.html
17

Nit: the animation-play-state: paused shouldn't be needed.

This revision is now accepted and ready to land.Dec 17 2018, 4:47 AM
heycam removed a reviewer: Restricted Project.Dec 17 2018, 4:48 AM
emilio updated this revision to Diff 44956.Dec 17 2018, 1:13 PM

+nits

Harbormaster completed remote builds in B27575: Diff 44956.Dec 17 2018, 1:13 PM
emilio marked 2 inline comments as done.Dec 17 2018, 1:14 PM
Closed by commit rMOZILLACENTRAL1b1eaa3248a7: Bug 1513920 - Make <use> shadow trees lookup keyframe rules in the containing… (authored by emilio). · Explain WhyDec 17 2018, 1:15 PM
This revision was automatically updated to reflect the committed changes.
Harbormaster completed remote builds in B27848: Diff 44957.Dec 19 2018, 4:32 AM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
servo/
components/
style/
85 lines92%
Loading...
6 lines72%
Loading...
testing/
web-platform/
tests/
svg/
linking/
reftests/
6 lines--
19 lines--

Diff 44957

View Options

servo/components/style/rule_collector.rs

Loading...
View Options

servo/components/style/stylist.rs

Loading...
View Options

testing/web-platform/tests/svg/linking/reftests/use-keyframes-ref.html

Loading...
View Options

testing/web-platform/tests/svg/linking/reftests/use-keyframes.html

Loading...
Privacy · Cookies · Legal