Details

Reviewers

Commits

rMOZILLACENTRAL5f325a8a1520: Bug 1765361: Only resolve objdir from virtualenv if mozinfo not ancestor…
rMOZILLACENTRALf05729424f4d: Bug 1765361: Only resolve objdir from virtualenv if mozinfo not ancestor…

Bugzilla Bug ID

1765361

Summary

Virtualenv-based objdir detection doesn't work for instrumented builds,
as instrumentation-specific objdirs aren't created.

Resolve this by:

Removing redundant cwd-based topsrcdir resolution - the __file__-based code path below covers this case.
Only using virtualenv-based resolving if topsrcdir isn't resolved.
Documenting that virtualenv-based resolution is problematic for instrumented builds.

Diff Detail

Repository: rMOZILLACENTRAL mozilla-central

Event Timeline

• mhentges created this revision.Apr 19 2022, 4:43 PM

Herald added a project: secure-revision. · View Herald TranscriptApr 19 2022, 4:43 PM

Harbormaster completed remote builds in B415499: Diff 568770.Apr 19 2022, 4:43 PM

phab-bot published this revision for review.Apr 19 2022, 4:43 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

• mhentges updated this revision to Diff 568771.Apr 19 2022, 4:43 PM

• mhentges edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B415500: Diff 568771.Apr 19 2022, 4:43 PM

• mhentges added a reviewer: glandium.Apr 19 2022, 4:44 PM

glandium accepted this revision.Apr 26 2022, 5:34 AM

This revision is now accepted and ready to land.Apr 26 2022, 5:34 AM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!