Page MenuHomePhabricator
Differential D14320

Bug 1322780 - Part 3: Let logical height, block-size, accept keywords.
ClosedPublic
Actions

Authored by boris on Dec 12 2018, 8:42 PM.

Details

Reviewers
emilio
Commits
Restricted Diffusion Commit
rMOZILLACENTRALecf13af1b421: Bug 1322780 - Part 3: Let logical height, block-size, accept keywords. r=emilio
Bugzilla Bug ID
1322780
Summary

We should let block-size/min-block-size/max-block-size accept keywords as the
initial value, just like width in vertical writing mode or height in horizontal
writing mode.

Depends on D7536

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

boris created this revision.Dec 12 2018, 8:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 12 2018, 8:42 PM
boris added a child revision: D13485: Bug 1322780 - Part 4: Add tests..Dec 12 2018, 8:43 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Dec 12 2018, 8:43 PM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.
Harbormaster completed remote builds in B26776: Diff 43753.Dec 12 2018, 8:43 PM
boris requested review of this revision.Dec 12 2018, 8:43 PM
Herald added a subscriber: emilio. · View Herald TranscriptDec 12 2018, 8:43 PM
boris retitled this revision from Bug 1322780 - Part 3: Let logical height accept keywords. to Bug 1322780 - Part 3: Let logical height, block-size, apply to keywords..Dec 12 2018, 8:46 PM
boris added a reviewer: emilio.
boris updated this revision to Diff 43820.Dec 12 2018, 10:31 PM
boris updated this revision to Diff 43850.Dec 13 2018, 1:08 AM
boris retitled this revision from Bug 1322780 - Part 3: Let logical height, block-size, apply to keywords. to Bug 1322780 - Part 3: Let logical height, block-size, accept keywords..
emilio accepted this revision.Dec 13 2018, 1:18 AM
emilio added a subscriber: mats.

So, code-wise this looks good, but it worries me that people can no longer detect whether we support block-size: -moz-available. https://bugzilla.mozilla.org/show_bug.cgi?id=1496694 was closed less than a day ago...

If WebKit somehow supports -webkit-fill-available in the block direction, maybe we should probably reject block-size: -moz-available? Though maybe it's not a big deal... @mats do you have any opinion here?

This revision is now accepted and ready to land.Dec 13 2018, 1:18 AM
boris added a comment.Dec 13 2018, 6:39 PM

I see. Either way is ok to me. Rejecting -moz-available and -moz-fit-content on block-size matches the current spec, so it would be fine.

boris added a reviewer: mats.Dec 13 2018, 8:48 PM
This revision now requires review to proceed.Dec 13 2018, 8:48 PM
boris added a comment.Dec 13 2018, 8:50 PM

Add @mats as the reviewer to make sure if we should support -moz-fit-content and -moz-available on block-size.

boris removed a reviewer: mats.Dec 18 2018, 6:40 PM
In D14320#361640, @boris wrote:

Add @mats as the reviewer to make sure if we should support -moz-fit-content and -moz-available on block-size.

Per the feedback from irc, it's fine to support all keywords assuming that we already support them on 'height'. I remove the reviewer because I got the feedback already.

This revision is now accepted and ready to land.Dec 18 2018, 6:40 PM
boris updated this revision to Diff 45599.Dec 18 2018, 6:47 PM
boris edited the summary of this revision. (Show Details)
Closed by commit rMOZILLACENTRALecf13af1b421: Bug 1322780 - Part 3: Let logical height, block-size, accept keywords. r=emilio (authored by boris). · Explain WhyDec 18 2018, 9:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
layout/
style/
test/
15 lines
48 lines
2 lines
servo/
components/
style/
properties/
longhands/
11 lines
values/
specified/
22 lines
testing/
web-platform/
tests/
css/
css-logical/
parsing/
29 lines
28 lines
29 lines
28 lines
29 lines
28 lines
29 lines
28 lines
29 lines
28 lines
29 lines
28 lines

Diff 45682

View Options

layout/style/test/property_database.js

Loading...
View Options

layout/style/test/test_box_size_keywords.html

Loading...
View Options

layout/style/test/test_value_computation.html

Loading...
View Options

servo/components/style/properties/longhands/position.mako.rs

Loading...
View Options

servo/components/style/values/specified/length.rs

Loading...
View Options

testing/web-platform/tests/css/css-logical/parsing/block-size-invalid.html

Loading...
View Options

testing/web-platform/tests/css/css-logical/parsing/block-size-valid.html

Loading...
View Options

testing/web-platform/tests/css/css-logical/parsing/inline-size-invalid.html

Loading...
View Options

testing/web-platform/tests/css/css-logical/parsing/inline-size-valid.html

Loading...
View Options

testing/web-platform/tests/css/css-logical/parsing/max-block-size-invalid.html

Loading...
View Options

testing/web-platform/tests/css/css-logical/parsing/max-block-size-valid.html

Loading...
View Options

testing/web-platform/tests/css/css-logical/parsing/max-inline-size-invalid.html

Loading...
View Options

testing/web-platform/tests/css/css-logical/parsing/max-inline-size-valid.html

Loading...
View Options

testing/web-platform/tests/css/css-logical/parsing/min-block-size-invalid.html

Loading...
View Options

testing/web-platform/tests/css/css-logical/parsing/min-block-size-valid.html

Loading...
View Options

testing/web-platform/tests/css/css-logical/parsing/min-inline-size-invalid.html

Loading...
View Options

testing/web-platform/tests/css/css-logical/parsing/min-inline-size-valid.html

Loading...
Privacy · Cookies · Legal