Bug 1749169 - Listen to discrete scroll events on Wayland. r=stransky
Needs RevisionPublic
Actions

Authored by emilio on Jan 9 2022, 1:57 AM.

Details

Reviewers

Bugzilla Bug ID

Summary

This matches the GTK4 behavior, and shouldn't change behavior on
GNOME+Wayland, since the deltas for mousewheel ticks are 1.0 there.

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Branch

default

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

emilio created this revision.Jan 9 2022, 1:57 AM

Herald added a project: secure-revision. · View Herald TranscriptJan 9 2022, 1:57 AM

Harbormaster completed remote builds in B386596: Diff 526048.Jan 9 2022, 1:57 AM

phab-bot published this revision for review.Jan 9 2022, 1:58 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a subscriber: karlt. · View Herald TranscriptJan 9 2022, 1:58 AM

stransky requested changes to this revision.Jan 10 2022, 11:13 AM

stransky added inline comments.

widget/gtk/nsWindow.cpp
5805	I don't think this is quite correct - we set GDK_SCROLL_MASK to eventWidget. I'm going to remove mContainer as a widget and use that for Wayland subsurface only so this may wait to mContainer removal.

This revision now requires changes to proceed.Jan 10 2022, 11:13 AM

emilio marked an inline comment as done.Jan 10 2022, 3:29 PM

emilio added inline comments.

widget/gtk/nsWindow.cpp
5805	Is there a bug # for that? Anyways this seemed to work everywhere I tried but sure.

stransky added inline comments.Jan 10 2022, 3:38 PM

widget/gtk/nsWindow.cpp
5805	No, that's just in my TODO list :)

stransky added inline comments.Sep 26 2024, 8:10 AM

widget/gtk/nsWindow.cpp
4595	May be worth to preserve the comments at least to keep the knowledge here.

Revision Contents
Changeset List

Path

Size

widget/

gtk/

nsWindow.cpp

53 lines

Diff 526048

View Options

Bug 1749169 - Listen to discrete scroll events on Wayland. r=stranskyNeeds RevisionPublicActions