Page MenuHomePhabricator
Differential D114978

Bug 1708883 - Fix extension icon alignment in the about:preferences categories sidebar. r?sfoster!
ClosedPublic
Actions

Authored by rpl on May 12 2021, 2:17 PM.
Tags
Referenced Files
Unknown Object (File)
Wed, Apr 16, 1:15 PM
Unknown Object (File)
Wed, Apr 16, 1:13 AM
Unknown Object (File)
Sun, Apr 13, 6:08 PM
Unknown Object (File)
Apr 10 2025, 5:10 PM
Unknown Object (File)
Mar 19 2025, 12:36 PM
Unknown Object (File)
Dec 3 2024, 8:12 AM
Unknown Object (File)
Dec 3 2024, 8:07 AM
Unknown Object (File)
Nov 7 2024, 3:17 AM
View All 28 Files
Subscribers
None

Details

Reviewers
sfoster
Group Reviewers
desktop-theme-reviewers
Commits
Restricted Diffusion Commit
rMOZILLACENTRAL95989e53b413: Bug 1708883 - Fix extension icon alignment in the about:preferences categories…
Bugzilla Bug ID
1708883
Summary

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rpl created this revision.May 12 2021, 2:17 PM
Herald added a project: secure-revision. · View Herald TranscriptMay 12 2021, 2:17 PM
Harbormaster completed remote builds in B320071: Diff 438279.May 12 2021, 2:17 PM
phab-bot published this revision for review.May 12 2021, 2:17 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Herald added a reviewer: desktop-theme-reviewers. · View Herald TranscriptMay 12 2021, 2:17 PM
rpl added inline comments.May 12 2021, 2:24 PM
toolkit/themes/shared/in-content/common.inc.css
1531–1533

I did notice this while I was looking other places where the extension icons are being used.

I didn't dig in the mercurial history to double-check when this was needed, but I think it may have been need for the icon that was used before Proton and it may have triggered the small alignment issue that I did notice.

Removing these two rule here seems to make the alignment to look as I would have expected:

rpl retitled this revision from Bug 1709655 - Fix extension icon alignment in the about:preferences categories sidebar. r?sfoster! to Bug 1708883 - Fix extension icon alignment in the about:preferences categories sidebar. r?sfoster!.May 12 2021, 3:06 PM
rpl edited the summary of this revision. (Show Details)
rpl changed the Bugzilla Bug ID from 1709655 to 1708883.
rpl removed a parent revision: D114884: Bug 1709655 - Update other about:addons category icons and remove extensionGeneric.svg chrome url overrides. r?sfoster!.
sfoster accepted this revision.May 12 2021, 7:32 PM
sfoster added a project: testing-exception-ui (Only changes ui styling, images, or localized strings).

Yeah, this looks much better, thanks.

This revision is now accepted and ready to land.May 12 2021, 7:32 PM
Closed by commit rMOZILLACENTRAL95989e53b413: Bug 1708883 - Fix extension icon alignment in the about:preferences categories… (authored by rpl). · Explain WhyMay 13 2021, 5:31 PM
This revision was automatically updated to reflect the committed changes.
rpl added a commit: rMOZILLACENTRAL95989e53b413: Bug 1708883 - Fix extension icon alignment in the about:preferences categories….
rpl added a commit: Restricted Diffusion Commit.May 24 2021, 8:34 PM

Revision Contents
Changeset List

PathSize
toolkit/
themes/
shared/
in-content/
3 lines

Diff 438676

View Options

toolkit/themes/shared/in-content/common.inc.css

Loading...
Privacy · Cookies · Legal