Page MenuHomePhabricator

Bug 1505639 - Factor texture cache handle lists into a helper struct.
ClosedPublic

Authored by bholley on Nov 8 2018, 1:07 AM.

Details

Reviewers
gw
Bugzilla Bug ID
1505639
Summary

This is a bit cleaner and avoids borrow checking problems.

Depends on D11416

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Branch
HEAD
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

bholley created this revision.Nov 8 2018, 1:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 8 2018, 1:07 AM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Nov 8 2018, 1:07 AM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.
bholley requested review of this revision.Nov 8 2018, 1:07 AM
bholley updated this revision to Diff 33701.Nov 9 2018, 1:11 AM
bholley edited the summary of this revision. (Show Details)
gw accepted this revision.Nov 9 2018, 1:54 AM
gw added inline comments.
gfx/webrender/src/texture_cache.rs
278

nit: Having this as an enum instead of a bool would make it easier to read calling code.

This revision is now accepted and ready to land.Nov 9 2018, 1:54 AM
bholley marked 2 inline comments as done.Nov 9 2018, 5:25 PM

Thanks for the reviews!

gfx/webrender/src/texture_cache.rs
278

Heh, I considered doing this before, but we already had an EntryKind, which also contained details in the cache case.

I've gone ahead and added two more patches on top of this stack, one to rename EntryKind to EntryDetails, and another to introduce a detail-less EntryKind, which I've used for this logic. Code is much nicer now. :-)

bholley closed this revision.Nov 9 2018, 7:31 PM
bholley marked an inline comment as done.