Bug 1504536 - Remove nscsspropertyid_is_{animatable,transitionable}.
ClosedPublic
Actions

Authored by emilio on Nov 4 2018, 3:03 PM.

Details

Reviewers

birtles
hiro

Group Reviewers

Restricted Project

Commits

Bugzilla Bug ID

1504536

Summary

There are better ways, plus the existing code didn't handle aliases at
all (not that it needed to, but it's better if it does).

Repository

rMOZILLACENTRAL mozilla-central

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Nov 4 2018, 3:03 PM

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: Restricted Project.

emilio requested review of this revision.Nov 4 2018, 3:03 PM

hiro added inline comments.

servo/components/style/properties/properties.mako.rs
477	Can we add a debug_assert to make sure that this function is NOT called a shorthand property? If someone tries to use this function for a shorthand, it apparently means a wrong thing to do.
484	Same here.

This revision is now accepted and ready to land.Nov 4 2018, 10:23 PM

emilio marked an inline comment as done.Nov 5 2018, 9:20 AM

emilio added inline comments.

servo/components/style/properties/properties.mako.rs
477	I can move them to `LonghandId` instead, but I'm not sure what would guarantee that the following is not called with a shorthand: https://searchfox.org/mozilla-central/rev/7c0a5e2aefd29b5b56923bc9fbc1180fc488b33c/dom/animation/KeyframeUtils.cpp#556 The transitionable bit is indeed not called with a shorthand, but that's an assertion that the transitions code should do (and does already).