Page MenuHomePhabricator
Differential D10804

Bug 1504387 - Remove preference "layout.css.shape-outside.enabled".
ClosedPublic
Actions

Authored by TYLin on Nov 3 2018, 3:30 AM.

Details

Reviewers
emilio
bradwerth
xidorn
Group Reviewers
Restricted Project
Commits
Restricted Diffusion Commit
rMOZILLACENTRAL6e528251fad4: Bug 1504387 - Remove preference "layout.css.shape-outside.enabled". r=bradwerth…
Bugzilla Bug ID
1504387
Summary

shape-outside, shape-margin, shape-image-threshold have been shipped in Firefox

  1. We can remove the preference.

The change in devtools/shared/css/generated/properties-db.js is generated by
"./mach devtools-css-db"

The actual shape-image CORS mode tests in file_shape_outside_CORS.html are
moved into test_shape_outside_CORS.html because we don't need the <iframe>
trick to enable the feature.

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

TYLin created this revision.Nov 3 2018, 3:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 3 2018, 3:30 AM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Nov 3 2018, 3:30 AM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.
Harbormaster completed remote builds in B19289: Diff 31424.Nov 3 2018, 3:30 AM
TYLin requested review of this revision.Nov 3 2018, 3:30 AM
Herald added a subscriber: emilio. · View Herald TranscriptNov 3 2018, 3:30 AM
TYLin added reviewers: Restricted Project, emilio, bradwerth.Nov 3 2018, 3:32 AM
xidorn accepted this revision as: xidorn.Nov 3 2018, 3:50 AM
This revision is now accepted and ready to land.Nov 3 2018, 3:50 AM
bradwerth accepted this revision.Nov 5 2018, 3:27 PM

I'm glad to see this cleaned up, thank you.

Closed by commit rMOZILLACENTRAL6e528251fad4: Bug 1504387 - Remove preference "layout.css.shape-outside.enabled". r=bradwerth… (authored by TYLin). · Explain WhyNov 5 2018, 7:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
devtools/
client/
shared/
5 lines
shared/
css/
generated/
12 lines
layout/
reftests/
w3c-css/
submitted/
shapes1/
2 lines
style/
test/
1 line
85 lines
65 lines
23 lines
modules/
libpref/
init/
3 lines
servo/
components/
style/
properties/
longhands/
3 lines
testing/
profiles/
unittest/
2 lines

Diff 31998

View Options

devtools/client/shared/output-parser.js

Loading...
View Options

devtools/shared/css/generated/properties-db.js

Loading...
View Options

layout/reftests/w3c-css/submitted/shapes1/reftest.list

Loading...
View Options

layout/style/test/file_shape_outside_CORS.html

Loading...
View Options

layout/style/test/mochitest.ini

Loading...
View Options

layout/style/test/property_database.js

Loading...
View Options

layout/style/test/test_shape_outside_CORS.html

Loading...
View Options

layout/style/test/test_transitions_per_property.html

Loading...
View Options

modules/libpref/init/all.js

Loading...
View Options

servo/components/style/properties/longhands/box.mako.rs

Loading...
View Options

testing/profiles/unittest/user.js

Loading...
Privacy · Cookies · Legal